From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: pg_dump/restore --no-tableam
Date: Mon, 17 Jan 2022 00:20:07 -0600
Message-ID: <20220117062006.GY14051@telsasoft.com> (raw)
In-Reply-To: <YeUE7izTxWMih7Dy@paquier.xyz>
References: <20200128133317.GZ13621@telsasoft.com>
<20211207153930.GR17618@telsasoft.com>
<20220103214424.GO24477@telsasoft.com>
<Yd02v3QnISIUZAuW@paquier.xyz>
<20220112040906.GE14051@telsasoft.com>
<YeUE7izTxWMih7Dy@paquier.xyz>
On Mon, Jan 17, 2022 at 02:55:58PM +0900, Michael Paquier wrote:
> On Tue, Jan 11, 2022 at 10:09:07PM -0600, Justin Pryzby wrote:
> > I suppose you're right - I had previously renamed it from no-tableam.
>
> Thanks for the new version. I have noticed that support for the
> option with pg_dumpall was missing, but that looks useful to me like
> the other switches.
I saw that you added it to pg_dumpall. But there's a typo in --help:
inline patch 1: src/bin/pg_dump/pg_dumpall.c (+1/-1 lines) download inline-1.patchdiff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.cindex 1cab0dfdc75..94852e7cdbb 100644--- a/src/bin/pg_dump/pg_dumpall.c+++ b/src/bin/pg_dump/pg_dumpall.c@@ -655,3 +655,3 @@ help(void)
printf(_(" --no-sync do not wait for changes to be written safely to disk\n"));
- printf(_(" --no-tables-access-method do not dump table access methods\n"));+ printf(_(" --no-table-access-method do not dump table access methods\n"));
printf(_(" --no-tablespaces do not dump tablespace assignments\n"));
Feel free to leave it for now, and I'll add it to my typos branch.
> And, done.
Thanks!
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, andres@anarazel.de
Subject: Re: pg_dump/restore --no-tableam
In-Reply-To: <20220117062006.GY14051@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox