pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f
Date: Wed, 9 Feb 2022 18:35:37 -0800
Message-ID: <20220210023537.GA3222837@rfd.leadboat.com> (raw)
In-Reply-To: <1075553.1642717844@sss.pgh.pa.us>
References: <E1nAIWI-0006et-HW@gemulon.postgresql.org>
	<CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com>
	<855583.1642687119@sss.pgh.pa.us>
	<867290.1642689136@sss.pgh.pa.us>
	<20220120192736.msyesvdlljn6tptw@alap3.anarazel.de>
	<926839.1642708567@sss.pgh.pa.us>
	<1075553.1642717844@sss.pgh.pa.us>

On Thu, Jan 20, 2022 at 05:30:44PM -0500, Tom Lane wrote:
> I wrote:
> > What I'm thinking of doing is inventing a "soft_stop" variant of
> > Cluster::stop that won't complain if pg_ctl stop fails, and then
> > having 017_shm's poll_start() call that before retrying the start
> > call.
> 
> I did that, modeling the details on Cluster::start's fail_ok option.

On AIX, this pair of commits added 5-10h of runtime to 017_shm.pl.

Before 6c4a890 or 4fdbf9a:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2022-01-19%2020%3A41%3A47
[21:14:17] t/017_shm.pl ......................... ok     7360 ms ( 0.01 usr  0.00 sys +  1.62 cusr  0.71 csys =  2.34 CPU)

After both:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2022-01-21%2021%3A03%3A28
[07:52:31] t/017_shm.pl ......................... ok 36908794 ms ( 0.00 usr  0.00 sys +  5.16 cusr 16.04 csys = 21.20 CPU)





view thread (20+ messages)  latest in thread

Message-ID: <20220210023537.GA3222837@rfd.leadboat.com>
Permalink:  ../20220210023537.GA3222837@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20220210023537.GA3222837@rfd.leadboat.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f
  In-Reply-To: <20220210023537.GA3222837@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox