pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Nathan Bossart <nathandbossart@gmail.com>
To: osumi.takamichi@fujitsu.com <osumi.takamichi@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>
Cc: wangw.fnst@fujitsu.com <wangw.fnst@fujitsu.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Greg Nancarrow <gregn4422@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Smith, Peter <peters@fast.au.fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Optionally automatically disable logical replication subscriptions on error
Date: Mon, 14 Mar 2022 16:04:24 -0700
Message-ID: <20220314230424.GA1085716@nathanxps13> (raw )
In-Reply-To: <TYCPR01MB83733807BF9349D8D0BD6DB4ED0F9@TYCPR01MB8373.jpnprd01.prod.outlook.com >
References: <CAA4eK1+6Gk9yRgEo8UbkJHut3jZLgdX30iULACMjeOgJefn9HA@mail.gmail.com >
<TYCPR01MB8373B74627C6BAF2F146D779ED099@TYCPR01MB8373.jpnprd01.prod.outlook.com >
<CAA4eK1+6_1fdo=EhLee_2OtX_bjj6chyeWtZexcKfSwAK3tuxQ@mail.gmail.com >
<TYCPR01MB83731B6EBA7D7ACF3C70B0F9ED0A9@TYCPR01MB8373.jpnprd01.prod.outlook.com >
<CAD21AoDgzFygdYJ9c5eSdYHP1YDkzkiEhzQvW5mrNCiPxkxKAw@mail.gmail.com >
<CAA4eK1KfdZ4kY5J7-KM9OoWHdUW2MuTdUUgBV+S53S3h7CREkw@mail.gmail.com >
<TYCPR01MB8373D74FC61748A668072D77ED0A9@TYCPR01MB8373.jpnprd01.prod.outlook.com >
<CAA4eK1Kes9TsMpGL6m+AJNHYCGRvx6piYQt5v6TEbH_t9jh8nA@mail.gmail.com >
<CAA4eK1JK2cW0gsFn==hgBR7K52Jkmb8R+cHiN+D8TbWjCSvdyw@mail.gmail.com >
<TYCPR01MB83733807BF9349D8D0BD6DB4ED0F9@TYCPR01MB8373.jpnprd01.prod.outlook.com >
My compiler is worried that syncslotname may be used uninitialized in
start_table_sync(). The attached patch seems to silence this warning.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Attachments:
v1-0001-silence-compiler-warning.patch (text/x-diff, 818B) download
From 05e4e03af5afa1658ede8d78b31c1c999b5c7deb Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathandbossart@gmail.com>
Date: Mon, 14 Mar 2022 16:00:18 -0700
Subject: [PATCH v1 1/1] silence compiler warning
---
src/backend/replication/logical/worker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c
index a1fe81b34f..03e069c7cd 100644
--- a/src/backend/replication/logical/worker.c
+++ b/src/backend/replication/logical/worker.c
@@ -3387,7 +3387,7 @@ TwoPhaseTransactionGid(Oid subid, TransactionId xid, char *gid, int szgid)
static void
start_table_sync(XLogRecPtr *origin_startpos, char **myslotname)
{
- char *syncslotname;
+ char *syncslotname = NULL;
Assert(am_tablesync_worker());
--
2.25.1
view thread (133+ messages) latest in thread
Message-ID: <20220314230424.GA1085716@nathanxps13>
Permalink: ../20220314230424.GA1085716@nathanxps13/
Also on: postgresql.org/message-id/20220314230424.GA1085716@nathanxps13
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, osumi.takamichi@fujitsu.com, amit.kapila16@gmail.com, sawada.mshk@gmail.com, smithpb2250@gmail.com, tanghy.fnst@fujitsu.com, wangw.fnst@fujitsu.com, vignesh21@gmail.com, gregn4422@gmail.com, mark.dilger@enterprisedb.com, peters@fast.au.fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Optionally automatically disable logical replication subscriptions on error
In-Reply-To: <20220314230424.GA1085716@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox