pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: src/test/perl/PostgreSQL/Test/*.pm not installed
Date: Mon, 10 Oct 2022 11:34:15 +0200
Message-ID: <20221010093415.poplkyn7pjeiv2y7@alvherre.pgsql> (raw)

I noticed that the new Perl test modules are not installed, so if you
try to use PostgreSQL/Test/Cluster.pm in an external test from pgxs, it
fails with the modules not being found.

I see no reason for this other than having overseen it in b235d41d9646,
so I propose the attached (for all branches, naturally.)

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La gente vulgar sólo piensa en pasar el tiempo;
el que tiene talento, en aprovecharlo"

Attachments:


install-perl-test.patch (text/x-diff, 1.4K) download
diff --git a/src/test/perl/Makefile b/src/test/perl/Makefile
index 3d3a95b52f..79f790772f 100644
--- a/src/test/perl/Makefile
+++ b/src/test/perl/Makefile
@@ -17,6 +17,7 @@ ifeq ($(enable_tap_tests),yes)
 
 installdirs:
 	$(MKDIR_P) '$(DESTDIR)$(pgxsdir)/$(subdir)'
+	$(MKDIR_P) '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test'
 
 install: all installdirs
 	$(INSTALL_DATA) $(srcdir)/TestLib.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/TestLib.pm'
@@ -24,6 +25,8 @@ install: all installdirs
 	$(INSTALL_DATA) $(srcdir)/RecursiveCopy.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/RecursiveCopy.pm'
 	$(INSTALL_DATA) $(srcdir)/PostgresNode.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgresNode.pm'
 	$(INSTALL_DATA) $(srcdir)/PostgresVersion.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgresVersion.pm'
+	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Cluster.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'
+	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Utils.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Utils.pm'
 
 uninstall:
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/TestLib.pm'
@@ -31,5 +34,7 @@ uninstall:
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/RecursiveCopy.pm'
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgresNode.pm'
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgresVersion.pm'
+	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'
+	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Utils.pm'
 
 endif

view thread (5+ messages)  latest in thread

Message-ID: <20221010093415.poplkyn7pjeiv2y7@alvherre.pgsql>
Permalink:  ../20221010093415.poplkyn7pjeiv2y7@alvherre.pgsql/
Also on:    postgresql.org/message-id/20221010093415.poplkyn7pjeiv2y7@alvherre.pgsql

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: src/test/perl/PostgreSQL/Test/*.pm not installed
  In-Reply-To: <20221010093415.poplkyn7pjeiv2y7@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox