From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Resolve partition strategy during early parsing
Date: Fri, 4 Nov 2022 11:19:35 -0500
Message-ID: <20221104161934.GB16921@telsasoft.com> (raw)
In-Reply-To: <E1oqcLs-000GqF-VN@gemulon.postgresql.org>
References: <E1oqcLs-000GqF-VN@gemulon.postgresql.org>
On Thu, Nov 03, 2022 at 03:41:56PM +0000, Alvaro Herrera wrote:
> Resolve partition strategy during early parsing
>
> This has little practical value, but there's no reason to let the
> partition strategy names travel through DDL as strings.
>
> Reviewed-by: Japin Li <japinli@hotmail.com>
> Discussion: https://postgr.es/m/20221021093216.ffupd7epy2mytkux@alvherre.pgsql
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/5fca91025e05f803140831953c09a36f08efcef5
This caused a warning in MSVC.
[16:10:46.225] c:\cirrus\src\backend\parser\gram.y(18435) : warning C4715: 'parsePartitionStrategy': not all control paths return a value
I'll send a patch to make cfbot warn about that soon.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: pryzby@telsasoft.com, alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Resolve partition strategy during early parsing
In-Reply-To: <20221104161934.GB16921@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox