pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Noah Misch <noah@leadboat.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: samay sharma <smilingsamay@gmail.com>
Subject: Re: CI and test improvements
Date: Tue, 17 Jan 2023 11:35:09 -0600
Message-ID: <20230117173509.GV9837@telsasoft.com> (raw)
In-Reply-To: <20230104234424.GE3109@telsasoft.com>
References: <20220828160752.l5l66k3eptokzhzj@awork3.anarazel.de>
	<20220828171029.GO2342@telsasoft.com>
	<20220828212802.r6eymfffrgr3lxxt@awork3.anarazel.de>
	<20220910200542.GX31833@telsasoft.com>
	<20221104235412.GE16921@telsasoft.com>
	<20221105015946.yrxijqb7h4rqhp6d@awork3.anarazel.de>
	<20221113235303.GA26337@telsasoft.com>
	<20221121224542.p2zapvyvb7objluw@alap3.anarazel.de>
	<20221122225744.GF11463@telsasoft.com>
	<20230104234424.GE3109@telsasoft.com>

The autoconf system runs all tap tests in t/*.pl, but meson requires
enumerating them in ./meson.build.

This checks for and finds no missing tests in the current tree:

$ for pl in `find src contrib -path '*/t/*.pl'`; do base=${pl##*/}; dir=${pl%/*}; meson=${dir%/*}/meson.build; grep "$base" "$meson" >/dev/null || echo "$base is missing from $meson"; done

However, this finds two real problems and one false-positive with
missing regress/isolation tests:

$ for makefile in `find src contrib -name Makefile`; do for testname in `sed -r '/^(REGRESS|ISOLATION) =/!d; s///; :l; /\\\\$/{s///; N; b l}; s/\n//g' "$makefile"`; do meson=${makefile%/Makefile}/meson.build; grep -Fw "$testname" "$meson" >/dev/null || echo "$testname is missing from $meson"; done; done
guc_privs is missing from src/test/modules/unsafe_tests/meson.build
oldextversions is missing from contrib/pg_stat_statements/meson.build
$(CF_PGP_TESTS) is missing from contrib/pgcrypto/meson.build

I also tried but failed to write something to warn if "meson test" was
run with a list of tests but without tmp_install.  Help wanted.

I propose to put something like this into "SanityCheck".

-- 
Justin





view thread (76+ messages)  latest in thread

Message-ID: <20230117173509.GV9837@telsasoft.com>
Permalink:  ../20230117173509.GV9837@telsasoft.com/
Also on:    postgresql.org/message-id/20230117173509.GV9837@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, andres@anarazel.de, andrew@dunslane.net, thomas.munro@gmail.com, noah@leadboat.com, michael@paquier.xyz, lubennikovaav@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, melanieplageman@gmail.com, peter.eisentraut@enterprisedb.com, daniel@yesql.se, smilingsamay@gmail.com
  Subject: Re: CI and test improvements
  In-Reply-To: <20230117173509.GV9837@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox