pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Noah Misch <noah@leadboat.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Andrei Lepikhov <lepihov@gmail.com>
Cc: jian he <jian.universality@gmail.com>
Cc: Artur Zakirov <zaartur@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: type cache cleanup improvements
Date: Fri, 11 Apr 2025 13:32:41 -0700
Message-ID: <20250411203241.e9.nmisch@google.com> (raw )
In-Reply-To: <CAPpHfdv=WVCbzdpoTxvXzUZZEqu_pDk2YZBnEGpUCrzuHxPN6w@mail.gmail.com >
References: <CAPpHfdt_dN5vyQQsTV=yeD+guDW7H7cvfkKj_mSETT0BEbyL+Q@mail.gmail.com >
<CAPpHfdvK8XS-FvXSxcEr-=azS3SHJo3b0yrQCq4uOv4fsw0JGw@mail.gmail.com >
<87y12i8i6f.fsf@wibble.ilmari.org >
<f8d8d179-ad31-4b46-aaef-3916be8bc8af@gmail.com >
<CAPpHfdvMVevMxAob4Yav9LyW2a4nrWqxUVQ8K1=Hs7EjOPQk1w@mail.gmail.com >
<87v7xl92x2.fsf@wibble.ilmari.org >
<CAPpHfduqZFZYL63Yx92pfAyiS8ACXyXSsnV1Geb_ecJTTU=Pmg@mail.gmail.com >
<CAPpHfdtHjPuLPoLGAqeUnttxy-PooJNB4piiZraLXK2C8e8vwg@mail.gmail.com >
<CALT9ZEHh4-K5ofp+EKO8MdCQJWMWkrq3mZstWPJda8feSdnT-g@mail.gmail.com >
<CAPpHfdv=WVCbzdpoTxvXzUZZEqu_pDk2YZBnEGpUCrzuHxPN6w@mail.gmail.com >
On Tue, Oct 22, 2024 at 08:33:24PM +0300, Alexander Korotkov wrote:
> On Tue, Oct 22, 2024 at 6:10 PM Pavel Borisov <pashkin.elfe@gmail.com> wrote:
> > On Tue, 22 Oct 2024 at 11:34, Alexander Korotkov <aekorotkov@gmail.com> wrote:
> >> I'm going to push this if no objections.
(This became commit b85a9d0.)
> + /* Call delete_rel_type_cache() if we actually cleared something */
> + if (hadTupDescOrOpclass)
> + delete_rel_type_cache_if_needed(typentry);
I think the intent was to maintain the invariant that a RelIdToTypeIdCacheHash
entry exists if and only if certain kinds of data appear in the TypeCacheHash
entry. However, TypeCacheOpcCallback() clears TCFLAGS_OPERATOR_FLAGS without
maintaining RelIdToTypeIdCacheHash. Is it right to do that?
view thread (66+ messages) latest in thread
Message-ID: <20250411203241.e9.nmisch@google.com>
Permalink: ../20250411203241.e9.nmisch@google.com/
Also on: postgresql.org/message-id/20250411203241.e9.nmisch@google.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, aekorotkov@gmail.com, pashkin.elfe@gmail.com, ilmari@ilmari.org, lepihov@gmail.com, jian.universality@gmail.com, zaartur@gmail.com, exclusion@gmail.com, teodor@sigaev.ru, aleksander@timescale.com, tgl@sss.pgh.pa.us, michael@paquier.xyz
Subject: Re: type cache cleanup improvements
In-Reply-To: <20250411203241.e9.nmisch@google.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox