pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Cc: Noah Misch <noah@leadboat.com>
Subject: "postmaster became multithreaded" is reachable
Date: Thu, 23 Jan 2025 13:22:13 -0500
Message-ID: <206317.1737656533@sss.pgh.pa.us> (raw)

ExitPostmaster() says:

    /*
     * There is no known cause for a postmaster to become multithreaded after
     * startup.  Recheck to account for the possibility of unknown causes.
     * This message uses LOG level, because an unclean shutdown at this point
     * would usually not look much different from a clean shutdown.
     */
    if (pthread_is_threaded_np() != 0)
        ereport(LOG,
                (errcode(ERRCODE_INTERNAL_ERROR),
                 errmsg_internal("postmaster became multithreaded"),
                 errdetail("Please report this to <%s>.", PACKAGE_BUGREPORT)));

We now have a report[1] of a way to trigger this error message.
It seems to boil down to "cause an error before PostmasterMain
has reached its test of pthread_is_threaded_np()", for example

$ # build with --enable-nls, using MacPorts' gettext package
$ unset LANG
$ postgres -D /foo
postgres: could not access directory "/foo": No such file or directory
Run initdb or pg_basebackup to initialize a PostgreSQL data directory.
2025-01-23 18:16:03.843 GMT [41524] LOG:  postmaster became multithreaded
2025-01-23 18:16:03.843 GMT [41524] DETAIL:  Please report this to <pgsql-bugs@lists.postgresql.org>.

I suggest therefore that we remove the "Please report a bug"
bit and instead use the much more helpful hint appearing in
PostmasterMain:

                 errhint("Set the LC_ALL environment variable to a valid locale.")));

An alternative idea (that maybe should also be done in PostmasterMain)
is to report the HINT only #ifdef __darwin__ and on other platforms
use the "Please report a bug" text.

			regards, tom lane

[1] https://www.postgresql.org/message-id/18783-d1873b95a59b9103%40postgresql.org





view thread (4+ messages)  latest in thread

Message-ID: <206317.1737656533@sss.pgh.pa.us>
Permalink:  ../206317.1737656533@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/206317.1737656533@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, noah@leadboat.com
  Subject: Re: "postmaster became multithreaded" is reachable
  In-Reply-To: <206317.1737656533@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox