pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Noah Misch <noah@leadboat.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Vik Fearing <vik@postgresfriends.org>
Cc: cary huang <hcary328@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Add support for AT LOCAL
Date: Mon, 16 Oct 2023 09:54:41 -0400
Message-ID: <2287835.1697464481@sss.pgh.pa.us> (raw)
In-Reply-To: <ZSzmdDenWESX5jmW@paquier.xyz>
References: <CA+hUKGL04vme+yztreEFhGucv2d9ema+8_a+i43EUFdpYCPXfw@mail.gmail.com>
	<ZSyYqySa74x_RAH_@paquier.xyz>
	<CA+hUKGLYaVJ7df+Uu=ctUunRcqUsGY55feVQa-1pzz1=PT=z3w@mail.gmail.com>
	<2188264.1697425365@sss.pgh.pa.us>
	<CA+hUKGJSEOVonGsYCiuhZXsBFCxXtjNyHGYvn-w9jykGo2PgqQ@mail.gmail.com>
	<2191749.1697427017@sss.pgh.pa.us>
	<20231016045804.c0@rfd.leadboat.com>
	<20231016055051.3a@rfd.leadboat.com>
	<2208907.1697435663@sss.pgh.pa.us>
	<20231016060510.72@rfd.leadboat.com>
	<ZSzmdDenWESX5jmW@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> Perhaps that's a stupid question..  But a server running under this
> environment fails the two following queries even for older branches,
> right?
> select timezone('UTC', '23:59:59.99-07'::timetz);
> select timezone('UTC', '23:59:00-07'::timetz);

One would expect, since the AT LOCAL syntax is just sugar for that.

I'm mighty tempted though to (a) add coverage for timetz_izone
to HEAD, and (b) backpatch the new tests, sans the AT LOCAL case,
to the back branches (maybe not v11).

			regards, tom lane





view thread (60+ messages)  latest in thread

Message-ID: <2287835.1697464481@sss.pgh.pa.us>
Permalink:  ../2287835.1697464481@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2287835.1697464481@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, noah@leadboat.com, thomas.munro@gmail.com, vik@postgresfriends.org, hcary328@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Add support for AT LOCAL
  In-Reply-To: <2287835.1697464481@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox