pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Meskes <meskes@postgresql.org>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Joshua D. Drake <jd@commandprompt.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: Thread-unsafe coding in ecpg
Date: Thu, 24 Jan 2019 00:23:04 -0500
Message-ID: <22937.1548307384@sss.pgh.pa.us> (raw )
In-Reply-To: <18693.1548302004@sss.pgh.pa.us >
References: <24002.1547944649@sss.pgh.pa.us >
<d441f5913b147e5b3e0eed4647f9839d926d90fc.camel@postgresql.org >
<29905.1548005448@sss.pgh.pa.us >
<29984.1548014676@sss.pgh.pa.us >
<0A3221C70F24FB45833433255569204D1FB6C47E@G01JPEXMBYT05 >
<21439.1548037255@sss.pgh.pa.us >
<0A3221C70F24FB45833433255569204D1FB6C4FA@G01JPEXMBYT05 >
<32316.1548040561@sss.pgh.pa.us >
<0A3221C70F24FB45833433255569204D1FB6C6C0@G01JPEXMBYT05 >
<13850.1548090570@sss.pgh.pa.us >
<20190121193512.tdmcnic2yjxlufaw@alap3.anarazel.de >
<20352.1548101123@sss.pgh.pa.us >
<0f02fb0d-0a80-0dad-a01e-e6879d24e48f@commandprompt.com >
<27185.1548102332@sss.pgh.pa.us >
<cf1f04ba-1cd8-2adf-10dc-d2d04de3331b@2ndQuadrant.com >
<38244c62-e1cc-40f5-d567-777540815c16@2ndQuadrant.com >
<d06a16bc-52d6-9f0d-2379-21242d7dbe81@2ndQuadrant.com >
<25026.1548284495@sss.pgh.pa.us >
<62a84a11-5d3e-1238-afd5-ec11ba91bb09@2ndQuadrant.com >
<9460.1548299404@sss.pgh.pa.us >
<18693.1548302004@sss.pgh.pa.us >
Oh, I just noticed something else: several of the ecpg test programs
contain
#ifdef WIN32
#ifdef _MSC_VER /* requires MSVC */
_configthreadlocale(_ENABLE_PER_THREAD_LOCALE);
#endif
#endif
Surely this is a kluge that we could now remove? We've protected the
only setlocale calls that the ecpg tests could reach in threaded mode.
If there is still a problem, it'd behoove us to find it, because
ecpglib should not expect that the calling app has done this for it.
regards, tom lane
view thread (37+ messages) latest in thread
Message-ID: <22937.1548307384@sss.pgh.pa.us>
Permalink: ../22937.1548307384@sss.pgh.pa.us/
Also on: postgresql.org/message-id/22937.1548307384@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, meskes@postgresql.org, andrew.dunstan@2ndquadrant.com, jd@commandprompt.com, andres@anarazel.de, tsunakawa.takay@jp.fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Thread-unsafe coding in ecpg
In-Reply-To: <22937.1548307384@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox