pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: add examples of creative use of unique expression indexes
Date: Fri, 10 Apr 2020 11:30:34 -0400
Message-ID: <2304.1586532634@sss.pgh.pa.us> (raw)
In-Reply-To: <E1ikvbp-0005jW-E9@gemulon.postgresql.org>
References: <E1ikvbp-0005jW-E9@gemulon.postgresql.org>

Bruce Momjian <bruce@momjian.us> writes:
> doc:  add examples of creative use of unique expression indexes
> https://git.postgresql.org/pg/commitdiff/a9760d0f3cb523336b5fdd9d6c5985e39a8588a1

We had a complaint [1] that this dropped an example into the middle of
two related paragraphs.  I agree with that objection, and also notice
that the extra example broke subsequent references to the "first example"
and "second example".  I'm also unhappy that the other addition that this
commit made was dropped inside Example 11.3; if we're going to use
<example> markup at all, each one ought to be a coherent entity.

On top of that, I don't find that either example actually adds anything
to the discussion, as the same points are being made in the existing
text.  Therefore, I don't think it's worth trying to fix these problems,
and propose just reverting this patch.

			regards, tom lane

[1] https://www.postgresql.org/message-id/158648685043.655.3074746555320970574%40wrigleys.postgresql.org





view thread (15+ messages)  latest in thread

Message-ID: <2304.1586532634@sss.pgh.pa.us>
Permalink:  ../2304.1586532634@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2304.1586532634@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: doc: add examples of creative use of unique expression indexes
  In-Reply-To: <2304.1586532634@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox