pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Numeric x^y for negative x
Date: Thu, 05 Aug 2021 12:04:39 -0400
Message-ID: <2394813.1628179479@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEZATCUWUV_BP41Ob7QY12oF+qDxjTWfDpkdkcOOuojrDvOLxw@mail.gmail.com>
References: <CAEZATCW6Dvq7+3wN3tt5jLj-FyOcUgT5xNoOqce5=6Su0bCR0w@mail.gmail.com>
	<CAEZATCUoVETahg892Qu3umjXX-V8J-F2xqQqunxckd5Se8KLyg@mail.gmail.com>
	<CAEZATCWAiXp7ocU3AMV6Pyvgv3O8x4-UBY+d=w+pziXXegdyOA@mail.gmail.com>
	<20210720181509.51a037ed0a8cb0f6d3ffda3a@sraoss.co.jp>
	<CAEZATCXGk5QQPRNjeXrd7EAkzhwwjgjLhEOp=zZwktX=zYradQ@mail.gmail.com>
	<20210722141136.573c11dfc06f4dd46b661bca@sraoss.co.jp>
	<CAEZATCW+yCy_11f56oDUecQzSrdO18gwPmOVwgbw6L0_HYJJeg@mail.gmail.com>
	<CAEZATCUWUV_BP41Ob7QY12oF+qDxjTWfDpkdkcOOuojrDvOLxw@mail.gmail.com>

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Thu, 22 Jul 2021 at 16:19, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>> Thanks for looking. Barring any further comments, I'll push this in a few days.

> So I have been testing this a lot over the last couple of days, and I
> have concluded that the patch works well as far as it goes, but I did
> manage to construct another case where numeric_power() loses
> precision. I think, though, that it would be better to tackle that as
> a separate patch.

It looks like castoroides is not happy with this patch:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=castoroides&dt=2021-08-01%2008%3A52%3A43

Maybe there's some hidden C99 dependency in what you did?
Although pademelon, which is one of our other pre-C99
dinosaurs, doesn't seem to be unhappy.

			regards, tom lane





view thread (27+ messages)  latest in thread

Message-ID: <2394813.1628179479@sss.pgh.pa.us>
Permalink:  ../2394813.1628179479@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2394813.1628179479@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dean.a.rasheed@gmail.com, nagata@sraoss.co.jp, pgsql-hackers@lists.postgresql.org
  Subject: Re: Numeric x^y for negative x
  In-Reply-To: <2394813.1628179479@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox