pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Noah Misch <noah@leadboat.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: kuroda.hayato@fujitsu.com <kuroda.hayato@fujitsu.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: FabrÃzio de Royes Mello <fabriziomello@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Subject: Re: speed up a logical replica setup
Date: Sun, 30 Jun 2024 14:58:00 -0400
Message-ID: <2509767.1719773880@sss.pgh.pa.us> (raw )
In-Reply-To: <2507765.1719772840@sss.pgh.pa.us >
References: <9a9c7e65-c47b-4400-a63e-ac6169c0860e@app.fastmail.com >
<65b841a8-0c2f-4953-b9cd-240fce84b90b@eisentraut.org >
<TYCPR01MB12077907C052EC329C45AE198F5362@TYCPR01MB12077.jpnprd01.prod.outlook.com >
<c8e92bcb-69c3-477e-93d4-6f39e030cab0@app.fastmail.com >
<47524383-6fd1-4b13-8c4e-fb918b1d35ba@enterprisedb.com >
<bbbeed26-41f9-468c-ac24-ad99f429ccd7@app.fastmail.com >
<CAA4eK1KPoLUUGzjw9eEQd56LUAf2QQj8BqMcsoSe6vycB5CYUQ@mail.gmail.com >
<2e86cf53-c806-49d2-9a10-1a1257776d1f@app.fastmail.com >
<CAA4eK1JJq_ER6Kq_H=jKHR75QPRd8y9_D=RtYw=aPYKMfqLi9A@mail.gmail.com >
<CAA4eK1KdCb+5sjYu6qCMXXdCX1y_ihr8kFzMozq0=P=auYxgog@mail.gmail.com >
<CANhcyEV6q1Vhd37i1axUeScLi0UAGVxta1LDa0BV0Eh--TcPMg@mail.gmail.com >
<CAA4eK1JaQcAZ=n513-4VDW4ujE9T9f007fczNCpVDbg1smhT4g@mail.gmail.com >
<5da4b286-e570-4341-8262-92d763f6b1a4@app.fastmail.com >
<776c5cac-5ef5-4001-b1bc-5b698bc0c62a@app.fastmail.com >
<3c024250-3f13-4f4d-b8e9-55f176db4abf@eisentraut.org >
<0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com >
<2377319.1719766794@sss.pgh.pa.us >
<2507765.1719772840@sss.pgh.pa.us >
I wrote:
> In hopes of moving things along as we approach the v18 branch,
> I went ahead and pushed Kuroda-san's patches (with a bit of
> further editorialization).
So b3f5ccebd promptly blew up on fairywren [1]:
connection error: 'psql: error: unterminated quoted string in connection info string'
while running 'psql -XAtq -d port=52984 host=C:/tools/nmsys64/tmp/hHg_pngw4z dbname='regression\\\\"\\\\ !"#$%&\\'()*+,-\\\\\\\\"\\\\\\\\\\\\' -f - -v ON_ERROR_STOP=1' at C:/tools/nmsys64/home/pgrunner/bf/root/HEAD/pgsql/src/test/perl/PostgreSQL/Test/Cluster.pm line 2124.
This shows that the command-line arguments to psql are not getting
adequately quoted on that platform. AFAICS, we are relying on
IPC::Run::run to perform such quoting, and it seems to be
falling down here. I wonder what version of IPC::Run fairywren
is using.
regards, tom lane
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2024-06-30%2018%3A03%3A06
view thread (320+ messages) latest in thread
Message-ID: <2509767.1719773880@sss.pgh.pa.us>
Permalink: ../2509767.1719773880@sss.pgh.pa.us/
Also on: postgresql.org/message-id/2509767.1719773880@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, peter@eisentraut.org, noah@leadboat.com, exclusion@gmail.com, euler@eulerto.com, amit.kapila16@gmail.com, shlok.kyal.oss@gmail.com, tomas.vondra@enterprisedb.com, kuroda.hayato@fujitsu.com, bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@lists.postgresql.org, michael@paquier.xyz, andres@anarazel.de, ashutosh.bapat.oss@gmail.com, fabriziomello@gmail.com, vignesh21@gmail.com
Subject: Re: speed up a logical replica setup
In-Reply-To: <2509767.1719773880@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox