pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: money type's overflow handling is woefully incomplete
Date: Tue, 12 Dec 2017 16:47:17 -0500
Message-ID: <25615.1513115237@sss.pgh.pa.us> (raw)
In-Reply-To: <20171212182153.wm7qrwfsfigciuck@alap3.anarazel.de>
References: <20171211225032.2phzzekso4337xmy@alap3.anarazel.de>
	<CA+TgmoZm1jgEV0hEtkaLx7Kj+uBOGKsT1gcX1id78Z6OwPahRQ@mail.gmail.com>
	<1420.1513094464@sss.pgh.pa.us>
	<20171212182153.wm7qrwfsfigciuck@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> Long story short, I don't think anyone cares about this enough to
>>> spend effort fixing it.  I suspect the money data type has very few
>>> users.

> I'm unfortunately not so sure :(.

There seem to be enough of them that we get pushback anytime somebody
suggests removing the type.

> The background is that I was working on committing the faster (&
> correct) overflow checks, and wanted to compile postgres with -ftrapv.
> Some rudimentary cash (as well as pgbench, rel/abstime) fixes were
> required to make the tests succeed...

Really?  We've got test cases that intentionally exercise overflow
in the money code?  I think we could just drop such tests, until
such time as someone fixes the issue.

(OTOH, I bet we could drop reltime/abstime without too many complaints.
Y2038 is coming.)

			regards, tom lane




view thread (9+ messages)  latest in thread

Message-ID: <25615.1513115237@sss.pgh.pa.us>
Permalink:  ../25615.1513115237@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/25615.1513115237@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com
  Subject: Re: money type's overflow handling is woefully incomplete
  In-Reply-To: <25615.1513115237@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox