From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Antonin Houska <ah@cybertec.at>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Mon, 20 Apr 2026 10:42:06 -0400
Message-ID: <260901.1776696126@sss.pgh.pa.us> (raw)
In-Reply-To: <aeYvFBkWT0V2_IUZ@alvherre.pgsql>
References: <aeYvFBkWT0V2_IUZ@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2026-Apr-20, Antonin Houska wrote:
>> Is this an attempt to disable REPACK (CONCURRENTLY)? That would require
>> wal_level=minimal (due to commit 67c20979ce). In which way does REPACK seem to
>> break test_plan_advice?
> No, quite the contrary. That test normally runs with wal_level=minimal,
> which causes REPACK to complain that it cannot start logical
> decoding.
So what you're saying is that the core regression tests will now fail
with wal_level=minimal? I don't see how that can possibly be
considered acceptable from a global standpoint; we might as well
remove wal_level=minimal, because it will never again get tested.
I think you need to move these tests out into some other test suite
(or make a new one).
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, ah@cybertec.at, pryzby@telsasoft.com, mihailnikalayeu@gmail.com, andres@anarazel.de, amit.kapila16@gmail.com, srinath2133@gmail.com, boekewurm+postgres@gmail.com, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <260901.1776696126@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox