From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: [postgresql 10 beta3] unrecognized node type: 90
Date: Fri, 11 Aug 2017 16:20:51 -0400
Message-ID: <27200.1502482851@sss.pgh.pa.us> (raw)
In-Reply-To: <11673.1502467154@sss.pgh.pa.us>
References: <CAL7LBcYM-32B=n_-h_wPHWiML26UvqP3b_WxD7MgXgOwmxvTFw@mail.gmail.com>
<11673.1502467154@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
I wrote:
> So, apparently somebody wrote ExecReScanGatherMerge, but never bothered
> to plug it into ExecReScan. From which we may draw depressing conclusions
> about how much it's been tested.
While I'm bitching ... the code coverage report at
https://coverage.postgresql.org/src/backend/executor/nodeGatherMerge.c.gcov.html
also leaves one with less than a warm feeling about the extent of test
coverage on this file. heap_compare_slots isn't invoked even once?
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: [postgresql 10 beta3] unrecognized node type: 90
In-Reply-To: <27200.1502482851@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox