pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org, Sami Imseih <samimseih@gmail.com>
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
Date: Sun, 07 Dec 2025 23:15:13 -0500
Message-ID: <2899652.1765167313@sss.pgh.pa.us> (raw)
In-Reply-To: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
References: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>

Michael Paquier <michael@paquier.xyz> writes:
> injection_points: Remove portions related to custom pgstats

BF member crake is unhappy with this, because it broke cross-version
update tests [1]:

pg_restore: while PROCESSING TOC:
pg_restore: from TOC entry 230; 1255 55098 FUNCTION injection_points_stats_drop() buildfarm
pg_restore: error: could not execute query: ERROR:  could not find function "injection_points_stats_drop" in file "/home/andrew/bf/root/saves.crake/HEAD/lib/postgresql/injection_points.so"
Command was: CREATE FUNCTION "public"."injection_points_stats_drop"() RETURNS "void"
    LANGUAGE "c" STRICT
    AS '$libdir/injection_points', 'injection_points_stats_drop';

I think that this is really a bug in the Xversion-update test, because
I don't see why we'd be holding src/test/modules libraries to the
standard of can-be-upgraded-across-versions.  But maybe there's
something I'm missing?

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2025-12-08%2003%3A47%3A03...





view thread (16+ messages)  latest in thread

Message-ID: <2899652.1765167313@sss.pgh.pa.us>
Permalink:  ../2899652.1765167313@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2899652.1765167313@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andrew@dunslane.net, samimseih@gmail.com
  Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
  In-Reply-To: <2899652.1765167313@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox