From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: craig@2ndquadrant.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: xact_start for walsender & logical decoding not updated
Date: Tue, 07 Jan 2020 18:12:43 -0500
Message-ID: <30804.1578438763@sss.pgh.pa.us> (raw)
In-Reply-To: <30549.1578438452@sss.pgh.pa.us>
References: <20200107211717.GA20056@alvherre.pgsql>
<30549.1578438452@sss.pgh.pa.us>
I wrote:
> The buildfarm seems less than happy with this.
... and, having now looked at the patch, I'm not surprised.
Breaking stmtStartTimestamp, which is what you did, seems like
an awfully side-effect-filled route to the goal. If you want
to prevent monitoring from showing this, why didn't you just
prevent monitoring from showing it? That is, I'd have expected
some am_walsender logic in or near pgstat.c, not here.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, tomas.vondra@2ndquadrant.com, horikyota.ntt@gmail.com, craig@2ndquadrant.com
Subject: Re: xact_start for walsender & logical decoding not updated
In-Reply-To: <30804.1578438763@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox