pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-committers@lists.postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>
Subject: Re: pgsql: Set random seed for pgbench.
Date: Fri, 30 Mar 2018 22:48:54 -0400
Message-ID: <32390.1522464534@sss.pgh.pa.us> (raw)
In-Reply-To: <E1f0U1H-00005J-98@gemulon.postgresql.org>
References: <E1f0U1H-00005J-98@gemulon.postgresql.org>

Teodor Sigaev <teodor@sigaev.ru> writes:
> Set random seed for pgbench.

So this patch has ignored the possibility of not having pg_strong_random.
That's moving the portability goalposts in a way that I do not find
acceptable for such a marginal feature.  What behavior do you think we
should have for platforms without that --- accept the seed=rand option
but then error out, or not recognize the option at all?

BTW, I also note that the patch is constructing error messages from
sentence fragments, which is verboten per translatability policy.
While that's perhaps not too important as long as we don't have message
translations for pgbench, it still seems like something to fix now not
later.

			regards, tom lane




view thread (7+ messages)  latest in thread

Message-ID: <32390.1522464534@sss.pgh.pa.us>
Permalink:  ../32390.1522464534@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/32390.1522464534@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, teodor@sigaev.ru, coelho@cri.ensmp.fr
  Subject: Re: pgsql: Set random seed for pgbench.
  In-Reply-To: <32390.1522464534@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox