pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Time to backpatch config/ax_pthread.m4 changes?
Date: Mon, 19 Nov 2018 12:12:45 -0500
Message-ID: <3320.1542647565@sss.pgh.pa.us> (raw)

I noticed that buildfarm member quokka (RHEL 7 / ppc64) has started
failing configure in the 9.4 and 9.5 branches.  This appears to be
because configure is not detecting the need to use "-pthread" to get
thread-related functions.  We didn't change anything in that area
ourselves, so I'm guessing that this is a result of a platform update,
which more than likely is going to start affecting other users before
long, so we'd better fix it.

It looks to me like the reason it's okay in 9.6 and up is
commit e97af6c8b ("Replace our hacked version of ax_pthread.m4 with
latest upstream version") plus a few followup fixes.  I propose to
back-patch those into 9.5 and 9.4.  Heikki had attempted to back-patch
into 9.5 originally, but gave up when the followup fixes seemed to
be getting out of hand --- but there weren't really that many.
Anyway, now that that code has been stable for several years, I see
little reason not to back-patch it.

			regards, tom lane




view thread (3+ messages)  latest in thread

Message-ID: <3320.1542647565@sss.pgh.pa.us>
Permalink:  ../3320.1542647565@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3320.1542647565@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, hlinnaka@iki.fi
  Subject: Re: Time to backpatch config/ax_pthread.m4 changes?
  In-Reply-To: <3320.1542647565@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox