pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Alexander Lakhin <exclusion@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: jian he <jian.universality@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: alvherre@alvh.no-ip.org
Subject: Re: Statistics Import and Export
Date: Sat, 1 Mar 2025 20:20:00 +0200
Message-ID: <339b3902-4e98-4e31-a744-94e43b7b9292@gmail.com> (raw )
In-Reply-To: <3043076.1740852261@sss.pgh.pa.us >
References: <sdno5atrplq5b67vcx7x6fkzevwkzojd23izbguy2yma424wmp@siwbi3ijxdxs >
<x5yo5ly5u3dhzfaq3hrzeqhju3io5zmwk4yqrkge3ywcflffck@ghbbgsfv56yb >
<3670503.1740173078@sss.pgh.pa.us >
<blezfpeafycxlizyynwvwzh2vywmklhvfqudhicjrccu4raqpx@4ttfufowc2vo >
<3728741.1740178078@sss.pgh.pa.us >
<CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com >
<97b451228227c555be1a4f79c4a62ddec9a74f06.camel@j-davis.com >
<CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com >
<b227c4fca29dfb893bb414ce6d84fc2377489ecc.camel@j-davis.com >
<CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com >
<y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw >
<6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com >
<57988cee-5cc8-44f9-981e-8d62e556f5c8@gmail.com >
<3043076.1740852261@sss.pgh.pa.us >
Hello Tom,
01.03.2025 20:04, Tom Lane wrote:
> Alexander Lakhin <exclusion@gmail.com> writes:
>> It looks like 8f427187d broke pg_dump on Cygwin:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2025-02-26%2010%3A03%3A07
> Yeah, Andrew and I have been puzzling over that off-list. pg_dump
> is definitely exiting unceremoniously.
>
>> As far as I can see, it exits prematurely here:
>> float reltuples = strtof(PQgetvalue(res, i, i_reltuples), NULL);
> I was suspecting those float conversions as a likely cause, but
> what do you think is wrong exactly? I see nothing obviously
> buggy in pg_strtof().
From my understanding, pg_strtof () can't stand against endptr == NULL.
I have changed that line to:
char *tptr;
float reltuples = strtof(PQgetvalue(res, i, i_reltuples), &tptr);
and 002_compare_backups passed for me.
Best regards,
Alexander Lakhin
Neon (https://neon.tech )
view thread (543+ messages) latest in thread
Message-ID: <339b3902-4e98-4e31-a744-94e43b7b9292@gmail.com>
Permalink: ../339b3902-4e98-4e31-a744-94e43b7b9292@gmail.com/
Also on: postgresql.org/message-id/339b3902-4e98-4e31-a744-94e43b7b9292@gmail.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, tgl@sss.pgh.pa.us, pgsql@j-davis.com, andres@anarazel.de, corey.huinker@gmail.com, michael@paquier.xyz, jian.universality@gmail.com, nathandbossart@gmail.com, bruce@momjian.us, boekewurm+postgres@gmail.com, magnus@hagander.net, sfrost@snowman.net, ashutosh.bapat.oss@gmail.com, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org, alvherre@alvh.no-ip.org
Subject: Re: Statistics Import and Export
In-Reply-To: <339b3902-4e98-4e31-a744-94e43b7b9292@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox