pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Fix comment in xlog.c
Date: Thu, 22 Jun 2017 15:44:58 +0900
Message-ID: <33e9617d-27f1-eee8-3311-e27af98eaf2b@lab.ntt.co.jp> (raw)
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Attached a patch for $SUBJECT.

- * If RecPtr is not NULL, try to read a record at that position.  Otherwise
+ * If RecPtr is valid, try to read a record at that position.  Otherwise

Commit 4d6d425ab8d addressed the comment above XLogReadRecord() in
xlogreader.c, but missed the same above ReadRecord() in xlog.c.

Backpatchable to 9.3, I'd think.

Thanks,
Amit

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachments:

xlog-comment-fix.patch (text/plain, 592B) download diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 70d2570dc2..197e9cc726 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -4132,7 +4132,7 @@ CleanupBackupHistory(void) /* * Attempt to read an XLOG record. * - * If RecPtr is not NULL, try to read a record at that position. Otherwise + * If RecPtr is valid, try to read a record at that position. Otherwise * try to read a record just after the last one previously read. * * If no valid record is available, returns NULL, or fails if emode is PANIC.

view thread (3+ messages)  latest in thread

Message-ID: <33e9617d-27f1-eee8-3311-e27af98eaf2b@lab.ntt.co.jp>
Permalink:  ../33e9617d-27f1-eee8-3311-e27af98eaf2b@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/33e9617d-27f1-eee8-3311-e27af98eaf2b@lab.ntt.co.jp

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: Langote_Amit_f8@lab.ntt.co.jp
  Subject: Re: Fix comment in xlog.c
  In-Reply-To: <33e9617d-27f1-eee8-3311-e27af98eaf2b@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox