pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Richard Wesley <richard@duckdblabs.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Query generates infinite loop
Date: Mon, 09 May 2022 00:02:57 -0400
Message-ID: <3603504.1652068977@sss.pgh.pa.us> (raw)
In-Reply-To: <CADkLM=dDM4TjiiBop4JWKz0jGk-XRX1nAovQd5cmzTODNbCr-g@mail.gmail.com>
References: <91B44E7B-68D5-448F-95C8-B4B3B0F5DEAF@duckdblabs.com>
	<CAFj8pRDzVzTfsnxs_T9T7k=HW_gWCryo==rVB-AX4R6pXo85xQ@mail.gmail.com>
	<2842828.1650474225@sss.pgh.pa.us>
	<3010353.1650490989@sss.pgh.pa.us>
	<CAMkU=1yp1S5cwj_e762D_tNHT5w=ZKDB3k6UCmSaTkbnddSwOA@mail.gmail.com>
	<CADkLM=dDM4TjiiBop4JWKz0jGk-XRX1nAovQd5cmzTODNbCr-g@mail.gmail.com>

Corey Huinker <corey.huinker@gmail.com> writes:
> On Wed, May 4, 2022 at 3:01 PM Jeff Janes <jeff.janes@gmail.com> wrote:
>> On Wed, Apr 20, 2022 at 5:43 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Oh --- looks like numeric generate_series() already throws error for
>>> this, so we should just make the timestamp variants do the same.

> This came up once before
> https://www.postgresql.org/message-id/CAB7nPqQUuUh_W3s55eSiMnt901Ud3meF7f_96yPkKcqfd1ZaMg%40mail.gma...

Oh!  I'd totally forgotten that thread, but given that discussion,
and particularly the counterexample at

https://www.postgresql.org/message-id/16807.1456091547%40sss.pgh.pa.us

it now feels to me like maybe this change was a mistake.  Perhaps
instead of the committed change, we ought to go the other way and
rip out the infinity checks in numeric generate_series().

In view of tomorrow's minor-release wrap, there is not time for
the sort of more leisured discussion that I now think this topic
needs.  I propose to revert eafdf9de0 et al before the wrap,
and think about this at more length before doing anything.

			regards, tom lane





view thread (12+ messages)  latest in thread

Message-ID: <3603504.1652068977@sss.pgh.pa.us>
Permalink:  ../3603504.1652068977@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3603504.1652068977@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, corey.huinker@gmail.com, jeff.janes@gmail.com, richard@duckdblabs.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Query generates infinite loop
  In-Reply-To: <3603504.1652068977@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox