From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: jian he <jian.universality@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tender Wang <tndrwang@gmail.com>
Subject: Re: not null constraints, again
Date: Fri, 08 Nov 2024 11:26:11 -0500
Message-ID: <3649828.1731083171@sss.pgh.pa.us> (raw)
In-Reply-To: <202411081308.nxj6dy2xui6a@alvherre.pgsql>
References: <202411081308.nxj6dy2xui6a@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> But we'll see what else the buildfarm has to say now that I pushed it ...
A lot of the buildfarm is saying
adder | 2024-11-08 13:04:39 | ../pgsql/src/backend/catalog/pg_constraint.c:708:37: warning: comparison is always true due to limited range of data type [-Wtype-limits]
which evidently is about this:
Assert(colnum > 0 && colnum <= MaxAttrNumber);
The memcpy right before that doesn't seem like project style either.
Most other places that are doing similar things just cast the
ARR_DATA_PTR to the right pointer type and dereference it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, jian.universality@gmail.com, pgsql-hackers@lists.postgresql.org, tndrwang@gmail.com
Subject: Re: not null constraints, again
In-Reply-To: <3649828.1731083171@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox