From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Bruce Momjian <bruce@momjian.us>
To: nat@makarevitch.org
To: pgsql-docs@lists.postgresql.org
Subject: Re: effective_cache_size
Date: Mon, 5 Nov 2018 12:50:01 +0100
Message-ID: <369ec766-b947-51bd-4dad-6fb9e026439f@2ndquadrant.com> (raw)
In-Reply-To: <20181016153820.GD31154@momjian.us>
References: <153685164808.22334.15432535018443165207@wrigleys.postgresql.org>
<20181011174849.GC7807@momjian.us>
<20181016153820.GD31154@momjian.us>
On 16/10/2018 17:38, Bruce Momjian wrote:
> diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
> index 2317e8b..e471d7f 100644
> --- a/src/backend/utils/misc/guc.c
> +++ b/src/backend/utils/misc/guc.c
> @@ -2987,10 +2987,9 @@ static struct config_int ConfigureNamesInt[] =
>
> {
> {"effective_cache_size", PGC_USERSET, QUERY_TUNING_COST,
> - gettext_noop("Sets the planner's assumption about the size of the disk cache."),
> - gettext_noop("That is, the portion of the kernel's disk cache that "
> - "will be used for PostgreSQL data files. This is measured in disk "
> - "pages, which are normally 8 kB each."),
> + gettext_noop("Sets the planner's assumption about the size of the data cache."),
> + gettext_noop("That is, the size of the cache used for PostgreSQL data files. "
> + "This is measured in disk pages, which are normally 8 kB each."),
> GUC_UNIT_BLOCKS,
> },
> &effective_cache_size,
This change completely loses the context that this is the kernel's/host
system's memory size. What is "data cache"? I think this is a bad
change. I know it's confusing, but the old description at least had
some basis in terms that are known to the user.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, bruce@momjian.us, nat@makarevitch.org, pgsql-docs@lists.postgresql.org
Subject: Re: effective_cache_size
In-Reply-To: <369ec766-b947-51bd-4dad-6fb9e026439f@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox