From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: pg_walinspect float4/float8 confusion
Date: Thu, 8 Sep 2022 13:53:10 +0200
Message-ID: <36ee692b-232f-0484-ce94-dc39d82021ad@enterprisedb.com> (raw)
The pg_walinspect function pg_get_wal_stats() has output arguments
declared as float4 (count_percentage, record_size_percentage, etc.), but
the internal computations are all done in type double. Is there a
reason why this is then converted to float4 for output? It probably
doesn't matter in practice, but it seems unnecessarily confusing. Or at
least add a comment so it doesn't look like an accident. Also compare
with pgstattuple, which uses float8 in its SQL interface for similar data.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com
Subject: Re: pg_walinspect float4/float8 confusion
In-Reply-To: <36ee692b-232f-0484-ce94-dc39d82021ad@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox