pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dipesh Pandit <dipesh.pandit@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Jeevan Ladhe <jeevanladhe.os@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
Cc: Abhijit Menon-Sen <ams@toroid.org>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c (zstd workers)
Date: Sun, 27 Mar 2022 13:47:47 -0400
Message-ID: <384291.1648403267@sss.pgh.pa.us> (raw )
In-Reply-To: <CA+Tgmobummc+reyzZJwnua7KXPC9sromDqYx1uoZ49mxq=LRfQ@mail.gmail.com >
References: <CA+TgmoaYrNxoGB8x_7Fk5uKXfbyMVAdSXTnfQN-1zu_3gB_v=Q@mail.gmail.com >
<20220314171152.GU28503@telsasoft.com >
<CA+TgmoYfV1ASq0QVR1QHaJnXfr+fPLoPByQL1SfWqjUuKtX_UA@mail.gmail.com >
<CA+TgmoYvpetyRAbbg1M8b3-iHsaN4nsgmWPjOENu5-doHuJ7fA@mail.gmail.com >
<20220317194130.GM28503@telsasoft.com >
<CA+TgmoaaDXOT+vFDcPrnXjPTU7oFPY2_pkeQFTdSGJfrqO2LNQ@mail.gmail.com >
<20220320194050.GX28503@telsasoft.com >
<CA+TgmoY90uUaqtx133BsH26ZabTRK-J5VoOsGga_wRw8+HdWpQ@mail.gmail.com >
<20220321131833.GB28503@telsasoft.com >
<CA+TgmoZz-F1pA1Vv=-6FOPWuS1eFi2ifNyySV4u6pW0+FBeG-g@mail.gmail.com >
<20220321182256.GC28503@telsasoft.com >
<CA+TgmoYJ=9Y=+fJ9WyAXAExTmpArCZEdRu1iVQ_2je+heTZGrg@mail.gmail.com >
<871qyvrvvm.fsf@wibble.ilmari.org >
<CA+Tgmobummc+reyzZJwnua7KXPC9sromDqYx1uoZ49mxq=LRfQ@mail.gmail.com >
Robert Haas <robertmhaas@gmail.com> writes:
> [ v5-0001-Replace-BASE_BACKUP-COMPRESSION_LEVEL-option-with.patch ]
Coverity has a nitpick about this:
/srv/coverity/git/pgsql-git/postgresql/src/common/backup_compression.c: 194 in parse_bc_specification()
193 /* Advance to next entry and loop around. */
>>> CID 1503251: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "vend" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
194 specification = vend == NULL ? kwend + 1 : vend + 1;
195 }
196 }
Not sure if you should remove this null-check or add some other ones,
but I think you ought to do one or the other.
regards, tom lane
view thread (32+ messages) latest in thread
Message-ID: <384291.1648403267@sss.pgh.pa.us>
Permalink: ../384291.1648403267@sss.pgh.pa.us/
Also on: postgresql.org/message-id/384291.1648403267@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, ilmari@ilmari.org, pryzby@telsasoft.com, dipesh.pandit@gmail.com, andres@anarazel.de, jeevanladhe.os@gmail.com, alvherre@alvh.no-ip.org, noriyoshi.shinoda@hpe.com, ams@toroid.org, 9erthalion6@gmail.com, jeevan.ladhe@enterprisedb.com, mark.dilger@enterprisedb.com, tushar.ahuja@enterprisedb.com
Subject: Re: refactoring basebackup.c (zstd workers)
In-Reply-To: <384291.1648403267@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox