From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Amul Sul <sulamul@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
Date: Mon, 25 Apr 2022 10:05:08 -0400
Message-ID: <39945.1650895508@sss.pgh.pa.us> (raw)
In-Reply-To: <202204251353.vgkpgcy3szt2@alvherre.pgsql>
References: <202204251353.vgkpgcy3szt2@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Hmm, so 027_stream_regress.pl is not prepared to deal with any unlogged
> tables that may be left in the regression database (which is what my
> spgist addition did). I first tried doing a TRUNCATE of the unlogged
> table, but that doesn't work either, and it turns out that the
> regression database does not have any UNLOGGED relations. Maybe that's
> something we need to cater for, eventually, but for now dropping the
> table suffices. I have pushed that.
It does seem like the onus should be on 027_stream_regress.pl to
deal with that, rather than restricting what the core tests can
leave behind.
Maybe we could have it look for unlogged tables and drop them
before making the dumps? Although I don't understand why
TRUNCATE wouldn't do the job equally well.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, sulamul@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
In-Reply-To: <39945.1650895508@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox