pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: postgres_fdw: batch inserts vs. before row triggers
Date: Fri, 25 Nov 2022 11:57:33 -0500
Message-ID: <4065383.1669395453@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPmGK15+iuR5vn-=ZGeLw+Lia2Qm9ZKVBowuWQKJ63inS0sRLQ@mail.gmail.com>
References: <CAPmGK16_uPqsmgK0-LpLSUk54_BoK13bPrhxhfjSoSTVz414hA@mail.gmail.com>
	<CAPmGK16RDXrFm-XoNkbigpbtJm4RYPZP-nb4NvcrXHkq-Uu24w@mail.gmail.com>
	<c85d5bfb-14f8-63b8-5a9c-9ea7db031b4b@enterprisedb.com>
	<CAPmGK14iHt3u4YkCGYKuPRJz80cmSmeakjskS36rZ7ZypgcNxA@mail.gmail.com>
	<CAPmGK17LpbTZs4m4a_6THP54UBeK9fHvX8aVVA+C6yEZDZwQcg@mail.gmail.com>
	<CAPmGK15onjpkn08k=TNvEuB2BR3_TaLTuH=DE9caFuCPghKzgg@mail.gmail.com>
	<CAPmGK16qutyCmyJJzgQOhfBq=NoGDqTB6O0QBZTihrbqre+oxA@mail.gmail.com>
	<CAPmGK17+mR5eYy3v1bs92NvpBoaCyehMKBSJyPG8xRN1fiVvSg@mail.gmail.com>
	<CAPmGK15+iuR5vn-=ZGeLw+Lia2Qm9ZKVBowuWQKJ63inS0sRLQ@mail.gmail.com>

Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> I have committed the patch.

Apologies for not having paid attention to this thread, but ...

I don't think the committed patch is acceptable at all, at least
not in the back branches, because it creates a severe ABI break.
Specifically, by adding a field to ResultRelInfo you have changed
the array stride of es_result_relations, and that will break any
previously-compiled extension code that accesses that array.

I'm not terribly pleased with it having added a field to EState
either.  That seems much more global than what we need here.
Couldn't we add the field to ModifyTableState, instead?

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <4065383.1669395453@sss.pgh.pa.us>
Permalink:  ../4065383.1669395453@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/4065383.1669395453@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, etsuro.fujita@gmail.com, tomas.vondra@enterprisedb.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: postgres_fdw: batch inserts vs. before row triggers
  In-Reply-To: <4065383.1669395453@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox