pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Adding CI to our tree
Date: Tue, 18 Jan 2022 21:50:07 -0500
Message-ID: <440239.1642560607@sss.pgh.pa.us> (raw)
In-Reply-To: <20220119011626.nw5cvugqfsy3fyob@alap3.anarazel.de>
References: <63f3be31-d7c4-0ff4-e5f4-7368863da1bc@dunslane.net>
	<20220114233411.2byuid4umwjqbhug@alap3.anarazel.de>
	<20220114235457.GQ14051@telsasoft.com>
	<87a81b91-87bf-c0bc-7e4f-06dffadcf737@dunslane.net>
	<20220117181946.bmvubqpzqxlvmgeh@alap3.anarazel.de>
	<CA+Tgmoap6WXzta=zw97SF73hCfzEWVMtfDFB01svYXMtTzKVVA@mail.gmail.com>
	<20220117192510.txue5mihjaxlngep@alap3.anarazel.de>
	<85428.1642447853@sss.pgh.pa.us>
	<20220117201619.3ltudwhgk2krmoki@alap3.anarazel.de>
	<20220118210847.GC23027@telsasoft.com>
	<20220119011626.nw5cvugqfsy3fyob@alap3.anarazel.de>

I just found one thing making check-world slower than it ought to be:
src/test/recovery/t/008_fsm_truncation.pl does

$node_primary->append_conf(
	'postgresql.conf', qq{
fsync = on
wal_log_hints = on
max_prepared_transactions = 5
autovacuum = off
});

There is no reason for this script to be overriding Cluster.pm's
fsync = off setting.  This actually causes parallel check-world to
fail altogether on florican's host, because the initial fsync of
the recovered primary takes more than 3 minutes when there's
conflicting I/O traffic, causing pg_ctl to time out.

This appears to go back to 917dc7d23 of 2016, so I think it just
predates our recognition that we should disable fsync in routine
tests.

			regards, tom lane





view thread (142+ messages)  latest in thread

Message-ID: <440239.1642560607@sss.pgh.pa.us>
Permalink:  ../440239.1642560607@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/440239.1642560607@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pryzby@telsasoft.com, robertmhaas@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, melanieplageman@gmail.com, peter.eisentraut@enterprisedb.com, daniel@yesql.se
  Subject: Re: Adding CI to our tree
  In-Reply-To: <440239.1642560607@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox