pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: postgres_fdw fails because GMT != UTC
Date: Thu, 04 Apr 2024 02:19:45 -0400
Message-ID: <465248.1712211585@sss.pgh.pa.us> (raw)

Over at [1] we have a complaint of postgres_fdw failing with
a remote-server error

> ERROR:  invalid value for parameter "TimeZone": "UTC"

I am not quite clear on how broken an installation needs to be to
reject "UTC" as a time zone setting, except that the breakage cannot
be subtle.  However, I notice that our code in pgtz.c and other
places treats "GMT" as a hard-wired special case ... but not "UTC".
I wonder if we ought to modify those places to force "UTC" down the
same hard-wired paths.  If we acted like that, this would have worked
no matter how misconfigured the installation was.

An alternative answer could be to change postgres_fdw to send "GMT"
not "UTC".  That's ugly from a standards-compliance viewpoint, but
it would fix this problem even with a non-updated remote server,
and I think postgres_fdw is generally intended to work with even
very old remote servers.

Or we could do both.

Thoughts?

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/5DF49366-10D1-42A4-99BF-F9A7DC3AB0F4%40mailbox.org





view thread (5+ messages)  latest in thread

Message-ID: <465248.1712211585@sss.pgh.pa.us>
Permalink:  ../465248.1712211585@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/465248.1712211585@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: postgres_fdw fails because GMT != UTC
  In-Reply-To: <465248.1712211585@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox