From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename
Date: Wed, 27 Apr 2022 23:28:18 -0400
Message-ID: <511362.1651116498@sss.pgh.pa.us> (raw)
In-Reply-To: <E1njsi7-001T1K-4n@gemulon.postgresql.org>
References: <E1njsi7-001T1K-4n@gemulon.postgresql.org>
Michael Paquier <michael@paquier.xyz> writes:
> This change replaces all calls to durable_rename_excl() with
> durable_rename(). This removes the protection against accidentally
> overwriting an existing file, but some platforms are already living
> without it, and all those code paths never expect an existing file (a
> couple of assertions are added to check after that, in case).
Assert'ing that an external (filesystem) condition holds seems like a bad
idea. See buildfarm.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename
In-Reply-To: <511362.1651116498@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox