pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
To: Maxim Orlov <orlovmg@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Japin Li <japinli@hotmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)
Date: Mon, 27 Nov 2023 10:00:00 +0300
Message-ID: <55d8800f-4a80-5256-1e84-246fbe79acd0@gmail.com> (raw)
In-Reply-To: <CAPpHfduwDL29rGb_ONKwAsmq6bfMRgP+y+QkZJFUWuv2rDpb4g@mail.gmail.com>
References: <CACG=ezYicZuhcmswFiwWtTxvTivj_yAAnynKw3OAYEJNgm+RWg@mail.gmail.com>
	<c41a591e-24fe-27cf-e187-a82b2c301174@iki.fi>
	<CAJ7c6TP052X56Ut+oxfgrWTF9X=1QBBW=dduiPO9qhP0FNEL_g@mail.gmail.com>
	<9fa7bef7-6a08-dd6e-b324-a69ccb30eb60@iki.fi>
	<CACG=ezb0_zsf1Ek=RxzpL+J1vs-eYSHat45GMya+LGXpPbr_Ow@mail.gmail.com>
	<4dd273c5-f594-1c04-3710-5811e62b18db@iki.fi>
	<CACG=ezY5+P5D1UwbEC3YmP-jxiDcB21TjB11FHQT5QCb_qtugg@mail.gmail.com>
	<CAJ7c6TPYPJ8YVD-GxjW-+Xdqodtoje+rVgQXUxdL2Kx+j5oG8w@mail.gmail.com>
	<b5f6c6ac-37da-b92d-a482-9171710d1a11@iki.fi>
	<CAJ7c6TPmzoPgj-4zdf+UqdV4GcoZag+=KTLpSJ3RHp5pYSxfZg@mail.gmail.com>
	<CAPpHfdtQhm1BXT9SL5jp1iOg=pN=A9pR98kwBCOQX4Pg=CY6mA@mail.gmail.com>
	<CAJ7c6TOUMe6izUX7r9t6zhK-X7La0fMgA4ru9BMniKAEv7pZKQ@mail.gmail.com>
	<CACG=ezbtS=nLBS6fedHxAjkBPRN-hyuHQ+su1VUtxWDsavDTYA@mail.gmail.com>
	<CACG=ezaOGAAmzqKjq=EDyqA6jNVtNFVvTc6-HstEy43swRqTog@mail.gmail.com>
	<CAPpHfduwDL29rGb_ONKwAsmq6bfMRgP+y+QkZJFUWuv2rDpb4g@mail.gmail.com>

Hello Alexander,

27.11.2023 02:43, Alexander Korotkov wrote:

> v61 looks good to me.  I'm going to push it as long as there are no objections.
>

I've looked at the patch set and found a typo:
occured

And a warning:
$ CC=gcc-12 CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-clobbered 
-Wno-missing-field-initializers" ./configure -q && make -s
slru.c:63:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
    63 | static int      inline
       | ^~~~~~

Maybe it's worth fixing before committing...

Best regards,
Alexander





view thread (135+ messages)  latest in thread

Message-ID: <55d8800f-4a80-5256-1e84-246fbe79acd0@gmail.com>
Permalink:  ../55d8800f-4a80-5256-1e84-246fbe79acd0@gmail.com/
Also on:    postgresql.org/message-id/55d8800f-4a80-5256-1e84-246fbe79acd0@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, aekorotkov@gmail.com, orlovmg@gmail.com, aleksander@timescale.com, hlinnaka@iki.fi, japinli@hotmail.com, andres@anarazel.de, michael@paquier.xyz, pashkin.elfe@gmail.com, peter.eisentraut@enterprisedb.com
  Subject: Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)
  In-Reply-To: <55d8800f-4a80-5256-1e84-246fbe79acd0@gmail.com>
  References: <CACG=ezYicZuhcmswFiwWtTxvTivj_yAAnynKw3OAYEJNgm+RWg@mail.gmail.com> <CAJ7c6TP052X56Ut+oxfgrWTF9X=1QBBW=dduiPO9qhP0FNEL_g@mail.gmail.com> <9fa7bef7-6a08-dd6e-b324-a69ccb30eb60@iki.fi> <CACG=ezb0_zsf1Ek=RxzpL+J1vs-eYSHat45GMya+LGXpPbr_Ow@mail.gmail.com> <4dd273c5-f594-1c04-3710-5811e62b18db@iki.fi> <CACG=ezY5+P5D1UwbEC3YmP-jxiDcB21TjB11FHQT5QCb_qtugg@mail.gmail.com> <CAJ7c6TPYPJ8YVD-GxjW-+Xdqodtoje+rVgQXUxdL2Kx+j5oG8w@mail.gmail.com> <b5f6c6ac-37da-b92d-a482-9171710d1a11@iki.fi> <CAJ7c6TPmzoPgj-4zdf+UqdV4GcoZag+=KTLpSJ3RHp5pYSxfZg@mail.gmail.com> <CAPpHfdtQhm1BXT9SL5jp1iOg=pN=A9pR98kwBCOQX4Pg=CY6mA@mail.gmail.com> <CAJ7c6TOUMe6izUX7r9t6zhK-X7La0fMgA4ru9BMniKAEv7pZKQ@mail.gmail.com> <CACG=ezbtS=nLBS6fedHxAjkBPRN-hyuHQ+su1VUtxWDsavDTYA@mail.gmail.com> <CACG=ezaOGAAmzqKjq=EDyqA6jNVtNFVvTc6-HstEy43swRqTog@mail.gmail.com> <CAPpHfduwDL29rGb_ONKwAsmq6bfMRgP+y+QkZJFUWuv2rDpb4g@mail.gmail.com> <55d8800f-4a80-5256-1e84-246fbe79acd0@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox