pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: bugfifx: a minor mistake in brin_inclusion.c comment
Date: Fri, 23 Mar 2018 01:32:55 +0100
Message-ID: <5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com> (raw)

Hi,

while looking at brin_inclusion.c, I've noticed that the comment about
INCLUSION_UNMERGEABLE and INCLUSION_CONTAINS_EMPTY uses incorrect values
(1 instead of 2). Attached is a simple fix.

But perhaps it would be better to use the constants in the comment.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

brin-inclusion-doc-fix.patch (text/x-patch, 764B) download diff --git a/src/backend/access/brin/brin_inclusion.c b/src/backend/access/brin/brin_inclusion.c index 2542877..d8042b0 100644 --- a/src/backend/access/brin/brin_inclusion.c +++ b/src/backend/access/brin/brin_inclusion.c @@ -60,9 +60,9 @@ * The values stored in the bv_values arrays correspond to: * * 0 - the union of the values in the block range - * 1 - whether an empty value is present in any tuple in the block range - * 2 - whether the values in the block range cannot be merged (e.g. an IPv6 + * 1 - whether the values in the block range cannot be merged (e.g. an IPv6 * address amidst IPv4 addresses). + * 2 - whether an empty value is present in any tuple in the block range */ #define INCLUSION_UNION 0 #define INCLUSION_UNMERGEABLE 1

view thread (2+ messages)  latest in thread

Message-ID: <5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com>
Permalink:  ../5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com/
Also on:    postgresql.org/message-id/5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com
  Subject: Re: bugfifx: a minor mistake in brin_inclusion.c comment
  In-Reply-To: <5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox