From: ikedarintarof <ikedarintarof@oss.nttdata.com>
To: pgsql-hackers@postgresql.org
Subject: doc: modify the comment in function libpqrcv_check_conninfo()
Date: Wed, 26 Jun 2024 21:52:55 +0900
Message-ID: <6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com> (raw)
Hi,
The function 'libpqrcv_check_conninfo()' returns 'void', but the comment
above says that the function returns true or false.
I've attached a patch to modify the comment.
Regard,
Rintaro Ikeda
Attachments:mod-doc.patch (text/x-diff, 810B) downloaddiff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.cindex 02f12f2921..851bf44fd3 100644--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c@@ -309,8 +309,8 @@ bad_connection:
* local filesystem access to be attempted.
*
* If the connection string can't be parsed, this function will raise
- * an error and will not return. If it can, it will return true if this- * connection string specifies a password and false otherwise.+ * an error. If it can, it will do nothing if this connection string+ * specifies a password and raise an error otherwise.
*/
static void
libpqrcv_check_conninfo(const char *conninfo, bool must_use_password)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ikedarintarof@oss.nttdata.com
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
In-Reply-To: <6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox