pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: benoit <benoit@hopsandfork.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan
Date: Mon, 26 Aug 2024 17:00:00 +0300
Message-ID: <6c68ac42-bbb5-8b24-103e-af0e279c536f@gmail.com> (raw)
In-Reply-To: <CAH2-Wz=78SnWZg+tbMhjGWqfRxYySk1uNYpGxfnL9vcQPWS8XQ@mail.gmail.com>
References: <CAH2-Wz=ksvN_sjcnD1+Bt-WtifRA5ok48aDYnq3pkKhxgMQpcw@mail.gmail.com>
	<CAEze2WhHixewkTRLhGMoMPOGmXNJBLnVNt7FuxgFpmzdricR0A@mail.gmail.com>
	<CAEze2WiPNet+Ff7wbyFUpLUPzCgUvdsoNSdo_KLcriSaDGWpow@mail.gmail.com>
	<CAH2-WzkUaZesPygO4DCv4F7QG3BpMMfDmB42S+C_KPn-jaa+yA@mail.gmail.com>
	<CAEze2WiYOpAytLraPs72FV1MvOP1Q6vZx04zHj++-ZWyNBkqUg@mail.gmail.com>
	<CAH2-WznZ5ebfv96DqpKArBBcdnCUxkMOhFGipRA5mdhPKjVHsg@mail.gmail.com>
	<CAH2-WzmQUhfpSZrvcDmyk1OtydYv=TWRYJdp75m6=9hUaeHbFA@mail.gmail.com>
	<CAH2-WzkPOyZaMVtPUT19CfGwRndDekEBmGw_rd+UqKyK9n2LdQ@mail.gmail.com>
	<CAH2-Wz=vA9F1yS2gsc==EbV7rgJ21YyV0MEtV-Q_ELN9QPOD6g@mail.gmail.com>
	<0539d3d3-a402-0a49-ed5e-26429dffc4bd@gmail.com>
	<CAH2-Wz=sUDC5Y6uzKq8VOnhGgevaFF_j8-T+z240k72d8emXXg@mail.gmail.com>
	<ef0f7c8b-a6fa-362e-6fd6-054950f947ca@gmail.com>
	<CAH2-Wz=yAk0M1Xs-mP534KRcsfCbLRaGdCMZ-a2REk8R1jFC+Q@mail.gmail.com>
	<CAH2-Wz=78SnWZg+tbMhjGWqfRxYySk1uNYpGxfnL9vcQPWS8XQ@mail.gmail.com>

Hello Peter,

22.04.2024 20:59, Peter Geoghegan wrote:
>
> Pushed a fix like that just now. 

I'm sorry to bother you again, but I've come across another assertion
failure. Please try the following query (I use a clean "postgres" database,
just after initdb):
EXPLAIN SELECT conname
   FROM pg_constraint WHERE conname IN ('pkey', 'ID')
   ORDER BY conname DESC;

SELECT conname
   FROM pg_constraint WHERE conname IN ('pkey', 'ID')
   ORDER BY conname DESC;

It fails for me as below:
                                                      QUERY PLAN
--------------------------------------------------------------------------------------------------------------------
  Index Only Scan Backward using pg_constraint_conname_nsp_index on pg_constraint  (cost=0.14..4.18 rows=2 width=64)
    Index Cond: (conname = ANY ('{pkey,ID}'::name[]))
(2 rows)

server closed the connection unexpectedly
...
with the stack trace:
...
#5  0x000055a49f81148d in ExceptionalCondition (conditionName=0x55a49f8bb540 "ItemIdHasStorage(itemId)",
     fileName=0x55a49f8bb4a8 "../../../../src/include/storage/bufpage.h", lineNumber=355) at assert.c:66
#6  0x000055a49f0f2ddd in PageGetItem (page=0x7f97cbf17000 "", itemId=0x7f97cbf2f064)
     at ../../../../src/include/storage/bufpage.h:355
#7  0x000055a49f0f9367 in _bt_checkkeys_look_ahead (scan=0x55a4a0ac4548, pstate=0x7ffd1a103670, tupnatts=2,
     tupdesc=0x7f97cb5d7be8) at nbtutils.c:4105
#8  0x000055a49f0f8ac3 in _bt_checkkeys (scan=0x55a4a0ac4548, pstate=0x7ffd1a103670, arrayKeys=true,
     tuple=0x7f97cbf18890, tupnatts=2) at nbtutils.c:3612
#9  0x000055a49f0ebb4b in _bt_readpage (scan=0x55a4a0ac4548, dir=BackwardScanDirection, offnum=20, firstPage=true)
     at nbtsearch.c:1863
...
(gdb) f 7
#7  0x000055a49f0f9367 in _bt_checkkeys_look_ahead (scan=0x55a4a0ac4548, pstate=0x7ffd1a103670, tupnatts=2,
     tupdesc=0x7f97cb5d7be8) at nbtutils.c:4105
4105            ahead = (IndexTuple) PageGetItem(pstate->page,
(gdb) p aheadoffnum
$1 = 24596
(gdb) p pstate->offnum
$2 = 20
(gdb) p pstate->targetdistance
$3 = -24576

Best regards,
Alexander





view thread (78+ messages)  latest in thread

Message-ID: <6c68ac42-bbb5-8b24-103e-af0e279c536f@gmail.com>
Permalink:  ../6c68ac42-bbb5-8b24-103e-af0e279c536f@gmail.com/
Also on:    postgresql.org/message-id/6c68ac42-bbb5-8b24-103e-af0e279c536f@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, pg@bowt.ie, boekewurm+postgres@gmail.com, tgl@sss.pgh.pa.us, tomas.vondra@enterprisedb.com, pgsql@j-davis.com, benoit@hopsandfork.com, aekorotkov@gmail.com, hlinnaka@iki.fi
  Subject: Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan
  In-Reply-To: <6c68ac42-bbb5-8b24-103e-af0e279c536f@gmail.com>
  References: <CAH2-Wz=ksvN_sjcnD1+Bt-WtifRA5ok48aDYnq3pkKhxgMQpcw@mail.gmail.com> <CAEze2WhHixewkTRLhGMoMPOGmXNJBLnVNt7FuxgFpmzdricR0A@mail.gmail.com> <CAEze2WiPNet+Ff7wbyFUpLUPzCgUvdsoNSdo_KLcriSaDGWpow@mail.gmail.com> <CAH2-WzkUaZesPygO4DCv4F7QG3BpMMfDmB42S+C_KPn-jaa+yA@mail.gmail.com> <CAEze2WiYOpAytLraPs72FV1MvOP1Q6vZx04zHj++-ZWyNBkqUg@mail.gmail.com> <CAH2-WznZ5ebfv96DqpKArBBcdnCUxkMOhFGipRA5mdhPKjVHsg@mail.gmail.com> <CAH2-WzmQUhfpSZrvcDmyk1OtydYv=TWRYJdp75m6=9hUaeHbFA@mail.gmail.com> <CAH2-WzkPOyZaMVtPUT19CfGwRndDekEBmGw_rd+UqKyK9n2LdQ@mail.gmail.com> <CAH2-Wz=vA9F1yS2gsc==EbV7rgJ21YyV0MEtV-Q_ELN9QPOD6g@mail.gmail.com> <0539d3d3-a402-0a49-ed5e-26429dffc4bd@gmail.com> <CAH2-Wz=sUDC5Y6uzKq8VOnhGgevaFF_j8-T+z240k72d8emXXg@mail.gmail.com> <ef0f7c8b-a6fa-362e-6fd6-054950f947ca@gmail.com> <CAH2-Wz=yAk0M1Xs-mP534KRcsfCbLRaGdCMZ-a2REk8R1jFC+Q@mail.gmail.com> <CAH2-Wz=78SnWZg+tbMhjGWqfRxYySk1uNYpGxfnL9vcQPWS8XQ@mail.gmail.com> <6c68ac42-bbb5-8b24-103e-af0e279c536f@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox