From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Rename nodes/relation.h => nodes/pathnodes.h ?
Date: Mon, 28 Jan 2019 10:18:48 -0500
Message-ID: <7719.1548688728@sss.pgh.pa.us> (raw)
In the pluggable-storage discussion, there was some talk of renaming
nodes/relation.h to avoid confusion with the new access/relation.h
header. I think this is a fine idea, not only because of that conflict
but because "relation.h" has never made a lot of sense as the file's
name.
After a bit of thought, I propose "pathnodes.h" as the new name.
That fits in with the other major headers in that directory
(primnodes.h, parsenodes.h, plannodes.h, execnodes.h), and it seems
like a reasonable summary of what's in it. Admittedly, Path nodes
as such are barely a third of the file's bulk; but I don't see any
equally pithy way to describe the rest of it, unless something like
planner_data.h, which is pretty unmelodious.
(There was some mention of trying to split relation.h into multiple
files, but I fail to see any advantage in that.)
Barring objections, I'm happy to go make this happen.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Rename nodes/relation.h => nodes/pathnodes.h ?
In-Reply-To: <7719.1548688728@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox