pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Add deduplication to nbtree.
Date: Mon, 02 Mar 2020 12:47:46 -0500
Message-ID: <7971.1583171266@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wzk+w8unuU5zEhUWG=2dZ+xbDbRiYRZmfWw41jr-PTWt6w@mail.gmail.com>
References: <E1j73sn-0003FQ-KO@gemulon.postgresql.org>
	<27003.1583087095@sss.pgh.pa.us>
	<CAH2-Wzn9_zQR9Q96JUyVBAdro52Ov6+bQ1zcE_FPxEVXGw-ebQ@mail.gmail.com>
	<29676.1583090977@sss.pgh.pa.us>
	<CAH2-WzmAufHiOku6AGiFD=81VQs5nYJ1L2YkhW1t+BH4CMsgRw@mail.gmail.com>
	<CAH2-Wz=Tz_e8e39qTs3Mt78P6XD9s3u7TdOUVrYZg2eTEgfB0w@mail.gmail.com>
	<5838.1583100843@sss.pgh.pa.us>
	<CAH2-WzkPR8KMwkL0ap976kmXwBCeukTeHz6fB-U__wvuP1S9Zg@mail.gmail.com>
	<CAH2-WznRH9zmUn3tthVgHp3KDNvqCEL-E2u+xTgQYeT2xtfHqw@mail.gmail.com>
	<1640.1583121984@sss.pgh.pa.us>
	<CAH2-Wzk+w8unuU5zEhUWG=2dZ+xbDbRiYRZmfWw41jr-PTWt6w@mail.gmail.com>

Another issue I just noticed is that src/tools/pginclude/cpluspluscheck
complains thusly:

./src/include/access/nbtree.h: In function 'void BTreeTupleSetPosting(IndexTupleData*, int, int)':
./src/include/access/nbtree.h:384: warning: comparison between signed and unsigned integer expressions

I suppose this can be silenced with an appropriate cast, and doing so
would seem like a good idea.

			regards, tom lane





view thread (22+ messages)  latest in thread

Message-ID: <7971.1583171266@sss.pgh.pa.us>
Permalink:  ../7971.1583171266@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/7971.1583171266@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add deduplication to nbtree.
  In-Reply-To: <7971.1583171266@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox