From: Erik Rijkers <er@xs4all.nl>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: improve comments of snapbuild.c
Date: Tue, 14 Mar 2017 22:03:21 +0100
Message-ID: <797c6c4496a1ae49cc69e90aa768bac2@xs4all.nl> (raw)
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Improvements (grammar/typos) in the comments in snapbuild.c
To be applied to master.
thanks,
Erik Rijkers
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackersAttachments:
[text/x-diff] snapbuild.c.diff (2.2K, ../797c6c4496a1ae49cc69e90aa768bac2@xs4all.nl/2-snapbuild.c.diff)
download | inline diff:--- src/backend/replication/logical/snapbuild.c.orig 2017-03-14 21:53:42.590196415 +0100+++ src/backend/replication/logical/snapbuild.c 2017-03-14 21:57:57.906539208 +0100@@ -34,7 +34,7 @@
* xid. That is we keep a list of transactions between snapshot->(xmin, xmax)
* that we consider committed, everything else is considered aborted/in
* progress. That also allows us not to care about subtransactions before they
- * have committed which means this modules, in contrast to HS, doesn't have to+ * have committed which means this module, in contrast to HS, doesn't have to
* care about suboverflowed subtransactions and similar.
*
* One complexity of doing this is that to e.g. handle mixed DDL/DML
@@ -82,7 +82,7 @@
* Initially the machinery is in the START stage. When an xl_running_xacts
* record is read that is sufficiently new (above the safe xmin horizon),
* there's a state transition. If there were no running xacts when the
- * runnign_xacts record was generated, we'll directly go into CONSISTENT+ * running_xacts record was generated, we'll directly go into CONSISTENT
* state, otherwise we'll switch to the FULL_SNAPSHOT state. Having a full
* snapshot means that all transactions that start henceforth can be decoded
* in their entirety, but transactions that started previously can't. In
@@ -273,7 +273,7 @@
/*
* Allocate a new snapshot builder.
*
- * xmin_horizon is the xid >=which we can be sure no catalog rows have been+ * xmin_horizon is the xid >= which we can be sure no catalog rows have been
* removed, start_lsn is the LSN >= we want to replay commits.
*/
SnapBuild *
@@ -1840,7 +1840,7 @@
char path[MAXPGPATH];
/*
- * We start of with a minimum of the last redo pointer. No new replication+ * We start off with a minimum of the last redo pointer. No new replication
* slot will start before that, so that's a safe upper bound for removal.
*/
redo = GetRedoRecPtr();
@@ -1898,7 +1898,7 @@
/*
* It's not particularly harmful, though strange, if we can't
* remove the file here. Don't prevent the checkpoint from
- * completing, that'd be cure worse than the disease.+ * completing, that'd be a cure worse than the disease.
*/
if (unlink(path) < 0)
{
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: er@xs4all.nl
Subject: Re: improve comments of snapbuild.c
In-Reply-To: <797c6c4496a1ae49cc69e90aa768bac2@xs4all.nl>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox