pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Renan Soares Lopes <renans.l@icloud.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone
Date: Fri, 18 Feb 2022 17:47:14 -0000
Message-ID: <7f6fabaa-3f8f-49ab-89ca-59fbfe633105@me.com> (raw )
Hello,I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?
Attachments:
0001-fix-table_to_xmlschema-regex-for-timestamp-with-time.patch (text/x-patch, 1.8K) download
From 24768b689638fc35edcdb378735ae2505315a151 Mon Sep 17 00:00:00 2001
From: Renan Lopes <renan.lopes@datarisk.io>
Date: Fri, 18 Feb 2022 14:36:30 -0300
Subject: [PATCH] fix: table_to_xmlschema regex for timestamp with time zone
---
src/backend/utils/adt/xml.c | 4 ++--
src/test/regress/sql/xmlmap.sql | 7 +++++++
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index 51773db..801ad8f 100644
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -3659,7 +3659,7 @@ map_sql_type_to_xmlschema_type(Oid typeoid, int typmod)
case TIMEOID:
case TIMETZOID:
{
- const char *tz = (typeoid == TIMETZOID ? "(+|-)\\p{Nd}{2}:\\p{Nd}{2}" : "");
+ const char *tz = (typeoid == TIMETZOID ? "(\\+|-)\\p{Nd}{2}:\\p{Nd}{2}" : "");
if (typmod == -1)
appendStringInfo(&result,
@@ -3682,7 +3682,7 @@ map_sql_type_to_xmlschema_type(Oid typeoid, int typmod)
case TIMESTAMPOID:
case TIMESTAMPTZOID:
{
- const char *tz = (typeoid == TIMESTAMPTZOID ? "(+|-)\\p{Nd}{2}:\\p{Nd}{2}" : "");
+ const char *tz = (typeoid == TIMESTAMPTZOID ? "(\\+|-)\\p{Nd}{2}:\\p{Nd}{2}" : "");
if (typmod == -1)
appendStringInfo(&result,
diff --git a/src/test/regress/sql/xmlmap.sql b/src/test/regress/sql/xmlmap.sql
index fde1b9e..13407ee 100644
--- a/src/test/regress/sql/xmlmap.sql
+++ b/src/test/regress/sql/xmlmap.sql
@@ -55,3 +55,10 @@ CREATE TABLE testxmlschema.test3
SELECT xmlforest(c1, c2, c3, c4) FROM testxmlschema.test3;
SELECT table_to_xml('testxmlschema.test3', true, true, '');
+
+
+-- test datetime with time zone
+
+CREATE TABLE testxmlschema.test4 (a timestamp with time zone default current_timestamp);
+SELECT table_to_xmlschema('testxmlschema.test4', true, true, '');
+
--
2.35.1
view thread (3+ messages) latest in thread
Message-ID: <7f6fabaa-3f8f-49ab-89ca-59fbfe633105@me.com>
Permalink: ../7f6fabaa-3f8f-49ab-89ca-59fbfe633105@me.com/
Also on: postgresql.org/message-id/7f6fabaa-3f8f-49ab-89ca-59fbfe633105@me.com
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: renans.l@icloud.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone
In-Reply-To: <7f6fabaa-3f8f-49ab-89ca-59fbfe633105@me.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox