pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Imai Yoshikazu <yoshikazu_i443@live.jp>
Cc: jesper.pedersen@redhat.com <jesper.pedersen@redhat.com>
Cc: Imai, Yoshikazu <imai.yoshikazu@jp.fujitsu.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: speeding up planning with partitions
Date: Fri, 29 Mar 2019 14:32:57 -0400
Message-ID: <8305.1553884377@sss.pgh.pa.us> (raw )
In-Reply-To: <5c83dbca-12b5-1acf-0e85-58299e464a26@lab.ntt.co.jp >
References: <CAKJS1f9XAePd2+8F4=wtHKdDdckgKcSoXb-ZbU8Wbt86mhLxKA@mail.gmail.com >
<0F97FA9ABBDBE54F91744A9B37151A512B45CD@g01jpexmbkw24 >
<53a80692-c68d-5e11-1014-6441b6e8ca5a@redhat.com >
<BYAPR20MB22790FAFA860B03602A9A7B4BC420@BYAPR20MB2279.namprd20.prod.outlook.com >
<d04c7027-2df8-bbd5-9a8f-9806e3ab3270@lab.ntt.co.jp >
<20519.1553288822@sss.pgh.pa.us >
<15573.1553639191@sss.pgh.pa.us >
<47d2fd82-3f70-077b-abc6-863e3fa23503@lab.ntt.co.jp >
<379243a6-33d5-af38-43c9-37120a0893bd@lab.ntt.co.jp >
<a9f76f49-c747-2145-683b-767ff5343d7b@lab.ntt.co.jp >
<CAKJS1f9N6POxkCsq1s_Qzshz-Jmr7Jpq-eJW=ZM=U-SUCPxoMw@mail.gmail.com! >
<ab390249-6aab-195e-bced-e7a427c3462f@lab.ntt.co.jp >
<CAKJS1f-UeJmCLeWgMdcY7Y_Tf2-ZjGFwqHSY2VENYmx2tp2uRQ@mail.gmail.com >
<18712.1553698656@sss.pgh.pa.us >
<5! 9737210-61bd-e583-4393-cc0a5ab52549@lab.ntt.co.jp >
<19663.1553749401@sss.pgh.pa.us >
<2a531b7c-8ced-f868-2e! f2-5cf33b92ef0f@lab.ntt.co.jp >
<23856.1553812684@sss.pgh.pa.us >
<5c83dbca-12b5-1acf-0e85-58299e464a26@lab.! ntt.co.jp >
Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
> On 2019/03/29 7:38, Tom Lane wrote:
>> 2. I seriously dislike what's been done in joinrels.c, too. That
>> really seems like a kluge (and I haven't had time to study it
>> closely).
> Those hunks account for the fact that pruned partitions, for which we no
> longer create RangeTblEntry and RelOptInfo, may appear on the nullable
> side of an outer join. We'll need a RelOptInfo holding a dummy path, so
> that outer join paths can be created with one side of join being dummy
> result path, which are built in the patch by build_dummy_partition_rel().
Just for the record, that code is completely broken: it falls over
badly under GEQO. (Try running the regression tests with
"alter system set geqo_threshold to 2".) However, the partitionwise
join code was completely broken for GEQO before this patch, too, so
I'm just going to log that as an open issue for the moment.
regards, tom lane
view thread (265+ messages) latest in thread
Message-ID: <8305.1553884377@sss.pgh.pa.us>
Permalink: ../8305.1553884377@sss.pgh.pa.us/
Also on: postgresql.org/message-id/8305.1553884377@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, Langote_Amit_f8@lab.ntt.co.jp, david.rowley@2ndquadrant.com, yoshikazu_i443@live.jp, jesper.pedersen@redhat.com, imai.yoshikazu@jp.fujitsu.com, amitlangote09@gmail.com, alvherre@2ndquadrant.com, robertmhaas@gmail.com, pryzby@telsasoft.com
Subject: Re: speeding up planning with partitions
In-Reply-To: <8305.1553884377@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox