pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tristan Partin <tristan@partin.io>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: meson's in-tree libpq header search order vs -Dextra_include_dirs
Date: Tue, 04 Nov 2025 06:25:05 +0000
Message-ID: <DDZP25P4VZ48.3LWMZBGA1K9RH@partin.io> (raw)
In-Reply-To: <CA+hUKGJk85+sDf4D=JSwuvA9a4-sy6fnM3B=CVaU9Rk2V4NE2g@mail.gmail.com>
References: <CA+hUKGKispvxLyrBn3=3mp0BB1N+RBYR5eE2guCOksnwEoOcPQ@mail.gmail.com>
	<DDYTK4ZKMASW.2JD86Q6T77IU1@partin.io>
	<230128.1762150488@sss.pgh.pa.us>
	<CA+hUKGJk85+sDf4D=JSwuvA9a4-sy6fnM3B=CVaU9Rk2V4NE2g@mail.gmail.com>

After my analysis in the other subthread, patch 1 looks ready to be 
committed. Patch 2 looks good to go, but maybe you should split the "set 
-e" changes into a separate commit. Not sure how much I like patch 
3 since it hardcodes $libdir as "lib" for the purposes of finding the 
header, but it's also kind of a last resort thing, so ¯\_(ツ)_/¯. Maybe 
it's best if the meson build just copies whatever the autotools build 
does?

-- 
Tristan Partin
Databricks (https://databricks.com)





view thread (16+ messages)  latest in thread

Message-ID: <DDZP25P4VZ48.3LWMZBGA1K9RH@partin.io>
Permalink:  ../DDZP25P4VZ48.3LWMZBGA1K9RH@partin.io/
Also on:    postgresql.org/message-id/DDZP25P4VZ48.3LWMZBGA1K9RH@partin.io

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tristan@partin.io, thomas.munro@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: meson's in-tree libpq header search order vs -Dextra_include_dirs
  In-Reply-To: <DDZP25P4VZ48.3LWMZBGA1K9RH@partin.io>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox