From: Nathan Bossart <nathandbossart@gmail.com>
To: Dave Cramer <davecramer@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: More protocol.h replacements this time into walsender.c
Date: Wed, 23 Jul 2025 10:40:45 -0500
Message-ID: <aIECfYfevCUpenBT@nathan> (raw)
In-Reply-To: <aIA2l5mmHz9Wp0i-@nathan>
References: <CADK3HH+owWVdnbmWH4NHG8=+kXA_wjsyEVLoY719iJnb=+tT6A@mail.gmail.com>
<aIA2l5mmHz9Wp0i-@nathan>
Committed. I noticed that there are several characters with no match in
protocol.h. It might be worth adding those.
In walsender.c:
1537: pq_sendbyte(ctx->out, 'w');
2353: case 'r':
2357: case 'h':
2361: case 'p':
2755: pq_sendbyte(&output_message, 's');
3367: pq_sendbyte(&output_message, 'w');
4138: pq_sendbyte(&output_message, 'k');
In walreceiver.c:
829: case 'w': /* WAL records */
853: case 'k': /* Keepalive */
1133: pq_sendbyte(&reply_message, 'r');
1237: pq_sendbyte(&reply_message, 'h');
In logical/worker.c:
3854: if (c == 'w')
3876: else if (c == 'k')
3895: else if (c == 's') /* Primary status update */
4127: pq_sendbyte(reply_message, 'r');
4298: pq_sendbyte(request_message, 'p');
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, davecramer@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: More protocol.h replacements this time into walsender.c
In-Reply-To: <aIECfYfevCUpenBT@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox