pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: fix ancient typo in transformRelOptions()
Date: Tue, 5 Aug 2025 16:03:33 -0500
Message-ID: <aJJxpfsDfiQ1VbJ5@nathan> (raw)

I noticed that this function has a "namspace" parameter.  The attached
patch adds the missing 'e'.

-- 
nathan

Attachments:

v1-0001-fix-ancient-typo-in-transformRelOptions.patch (text/plain, 2.7K) download From 3f1431517cee250f1280adca739de0d6b9c77080 Mon Sep 17 00:00:00 2001 From: Nathan Bossart <nathan@postgresql.org> Date: Tue, 5 Aug 2025 16:01:34 -0500 Subject: [PATCH v1 1/1] fix ancient typo in transformRelOptions() --- src/backend/access/common/reloptions.c | 10 +++++----- src/include/access/reloptions.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c index 594a657ea1a..852cd73f5da 100644 --- a/src/backend/access/common/reloptions.c +++ b/src/backend/access/common/reloptions.c @@ -1164,7 +1164,7 @@ add_local_string_reloption(local_relopts *relopts, const char *name, * but we declare them as Datums to avoid including array.h in reloptions.h. */ Datum -transformRelOptions(Datum oldOptions, List *defList, const char *namspace, +transformRelOptions(Datum oldOptions, List *defList, const char *namespace, const char *const validnsps[], bool acceptOidsOff, bool isReset) { Datum result; @@ -1200,14 +1200,14 @@ transformRelOptions(Datum oldOptions, List *defList, const char *namspace, int kw_len; /* ignore if not in the same namespace */ - if (namspace == NULL) + if (namespace == NULL) { if (def->defnamespace != NULL) continue; } else if (def->defnamespace == NULL) continue; - else if (strcmp(def->defnamespace, namspace) != 0) + else if (strcmp(def->defnamespace, namespace) != 0) continue; kw_len = strlen(def->defname); @@ -1277,14 +1277,14 @@ transformRelOptions(Datum oldOptions, List *defList, const char *namspace, } /* ignore if not in the same namespace */ - if (namspace == NULL) + if (namespace == NULL) { if (def->defnamespace != NULL) continue; } else if (def->defnamespace == NULL) continue; - else if (strcmp(def->defnamespace, namspace) != 0) + else if (strcmp(def->defnamespace, namespace) != 0) continue; /* diff --git a/src/include/access/reloptions.h b/src/include/access/reloptions.h index dfbb4c85460..320f68ead8f 100644 --- a/src/include/access/reloptions.h +++ b/src/include/access/reloptions.h @@ -233,7 +233,7 @@ extern void add_local_string_reloption(local_relopts *relopts, const char *name, fill_string_relopt filler, int offset); extern Datum transformRelOptions(Datum oldOptions, List *defList, - const char *namspace, const char *const validnsps[], + const char *namespace, const char *const validnsps[], bool acceptOidsOff, bool isReset); extern List *untransformRelOptions(Datum options); extern bytea *extractRelOptions(HeapTuple tuple, TupleDesc tupdesc, -- 2.39.5 (Apple Git-154)

view thread (10+ messages)  latest in thread

Message-ID: <aJJxpfsDfiQ1VbJ5@nathan>
Permalink:  ../aJJxpfsDfiQ1VbJ5@nathan/
Also on:    postgresql.org/message-id/aJJxpfsDfiQ1VbJ5@nathan

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com
  Subject: Re: fix ancient typo in transformRelOptions()
  In-Reply-To: <aJJxpfsDfiQ1VbJ5@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox