From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: fix comment for MAX_SIMUL_LWLOCKS
Date: Tue, 19 Aug 2025 16:34:56 -0500
Message-ID: <aKTuAHVEuYCUmmIy@nathan> (raw)
This comment mentions that pg_buffercache locks all buffer partitions
simultaneously, but it hasn't done so since v10 (see commit 6e654546fb).
--
nathan
From 68b81e3bf70d5da0a0e2d0a0087218df7fde1101 Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Tue, 19 Aug 2025 16:27:33 -0500
Subject: [PATCH v1 1/1] Fix comment for MAX_SIMUL_LWLOCKS.
This comment mentions that pg_buffercache locks all buffer
partitions simultaneously, but it hasn't done so since v10.
Oversight in commit 6e654546fb.
---
src/backend/storage/lmgr/lwlock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.cindex ec9c345ffdf..c80b43f1f55 100644--- a/src/backend/storage/lmgr/lwlock.c+++ b/src/backend/storage/lmgr/lwlock.c@@ -162,8 +162,7 @@ LWLockPadded *MainLWLockArray = NULL;
/*
* We use this structure to keep track of locked LWLocks for release
* during error recovery. Normally, only a few will be held at once, but
- * occasionally the number can be much higher; for example, the pg_buffercache- * extension locks all buffer partitions simultaneously.+ * occasionally the number can be much higher.
*/
#define MAX_SIMUL_LWLOCKS 200
--
2.39.5 (Apple Git-154)
Attachments:
[text/plain] v1-0001-Fix-comment-for-MAX_SIMUL_LWLOCKS.patch (1.1K, ../aKTuAHVEuYCUmmIy@nathan/2-v1-0001-Fix-comment-for-MAX_SIMUL_LWLOCKS.patch)
download | inline diff:
From 68b81e3bf70d5da0a0e2d0a0087218df7fde1101 Mon Sep 17 00:00:00 2001
From: Nathan Bossart <nathan@postgresql.org>
Date: Tue, 19 Aug 2025 16:27:33 -0500
Subject: [PATCH v1 1/1] Fix comment for MAX_SIMUL_LWLOCKS.
This comment mentions that pg_buffercache locks all buffer
partitions simultaneously, but it hasn't done so since v10.
Oversight in commit 6e654546fb.
---
src/backend/storage/lmgr/lwlock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.cindex ec9c345ffdf..c80b43f1f55 100644--- a/src/backend/storage/lmgr/lwlock.c+++ b/src/backend/storage/lmgr/lwlock.c@@ -162,8 +162,7 @@ LWLockPadded *MainLWLockArray = NULL;
/*
* We use this structure to keep track of locked LWLocks for release
* during error recovery. Normally, only a few will be held at once, but
- * occasionally the number can be much higher; for example, the pg_buffercache- * extension locks all buffer partitions simultaneously.+ * occasionally the number can be much higher.
*/
#define MAX_SIMUL_LWLOCKS 200
--
2.39.5 (Apple Git-154)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com
Subject: Re: fix comment for MAX_SIMUL_LWLOCKS
In-Reply-To: <aKTuAHVEuYCUmmIy@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox