pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed From: Zhang Mingli <zmlpostgres@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: [Code Comments]enum COPY_NEW_FE is removed
Date: Sat, 6 Aug 2022 19:20:25 +0800
Message-ID: <aeec12a3-501e-449a-8d25-901c4ff706cf@Spark> (raw )
In-Reply-To: <920cf618-daed-4a1f-9984-c43eaaa8debe@Spark >
References: <920cf618-daed-4a1f-9984-c43eaaa8debe@Spark >
Hi,
Enum COPY_NEW_FE is removed in commit 3174d69fb9.
Should use COPY_FRONTEND instead.
Issue exists on 15 and master.
```
typedef struct CopyFromStateData
- StringInfo fe_msgbuf; /* used if copy_src == COPY_NEW_FE */
+ StringInfo fe_msgbuf; /* used if copy_src == COPY_FRONTEND */
```
Regards,
Zhang Mingli
Attachments:
v-0001-Fix-code-comments-COPY_FRONTEND.patch (application/octet-stream, 1.1K) download
From 5da5282cc29e45bda35a6e29ad8f87d6745f4856 Mon Sep 17 00:00:00 2001
From: Mingli Zhang <avamingli@gmail.com>
Date: Sat, 6 Aug 2022 19:08:42 +0800
Subject: [PATCH vn] Fix code comments COPY_FRONTEND
COPY_NEW_FE is removed in commit 3174d69fb9.
Use COPY_FRONTEND instead.
Backpatch-through: 15
Discussion: xxx
Reviewed-by: xxx
---
src/include/commands/copyfrom_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/include/commands/copyfrom_internal.h b/src/include/commands/copyfrom_internal.h
index 3df1c5a97c..e37c6032ae 100644
--- a/src/include/commands/copyfrom_internal.h
+++ b/src/include/commands/copyfrom_internal.h
@@ -58,7 +58,7 @@ typedef struct CopyFromStateData
/* low-level state data */
CopySource copy_src; /* type of copy source */
FILE *copy_file; /* used if copy_src == COPY_FILE */
- StringInfo fe_msgbuf; /* used if copy_src == COPY_NEW_FE */
+ StringInfo fe_msgbuf; /* used if copy_src == COPY_FRONTEND */
EolType eol_type; /* EOL type of input */
int file_encoding; /* file or remote side's character encoding */
--
2.34.1
view thread (3+ messages) latest in thread
Message-ID: <aeec12a3-501e-449a-8d25-901c4ff706cf@Spark>
Permalink: ../aeec12a3-501e-449a-8d25-901c4ff706cf@Spark/
Also on: postgresql.org/message-id/aeec12a3-501e-449a-8d25-901c4ff706cf@Spark
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: zmlpostgres@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [Code Comments]enum COPY_NEW_FE is removed
In-Reply-To: <aeec12a3-501e-449a-8d25-901c4ff706cf@Spark>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox