pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Joshua D. Drake <jd@commandprompt.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: replication_slots usability issue
Date: Fri, 2 Nov 2018 15:51:34 +0100
Message-ID: <c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com> (raw)
In-Reply-To: <20181101175423.7kbdn4n2w4vg6qzf@alap3.anarazel.de>
References: <56672097-711c-126a-a63e-04e7940110ad@commandprompt.com>
	<20181029190218.uejy5cvgzygwrguy@alvherre.pgsql>
	<20181029191304.lbsmhshkyymhw22w@alap3.anarazel.de>
	<20181030025109.GD1644@paquier.xyz>
	<20181030175254.wqircsg36vblpmw5@alap3.anarazel.de>
	<20181031224802.lamhfjil7uwpfiee@alap3.anarazel.de>
	<20181101003405.GB1727@paquier.xyz>
	<20181101175423.7kbdn4n2w4vg6qzf@alap3.anarazel.de>

On 01/11/2018 18:54, Andres Freund wrote:>
>> Also, from 691d79a which you just committed:
>> +       ereport(FATAL,
>> +               (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
>> +                errmsg("logical replication slots \"%s\" exists, but wal_level < logical",
>> +                       NameStr(cp.slotdata.name)),
>> I can see one grammar mistake here, as you refer to only one slot here.
>> The error messages should read:
>> "logical replication slot \"%s\" exists, but wal_level < logical"
>> and:
>> "physical replication slot \"%s\" exists, but wal_level < replica"
> 
> Darnit. Fixed. Thanks.
> 

Since we are fixing this message, shouldn't the hint for logical slot
say "Change wal_level to be logical or higher" rather than "replica or
higher" :)

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services




view thread (16+ messages)  latest in thread

Message-ID: <c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com>
Permalink:  ../c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com/
Also on:    postgresql.org/message-id/c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: petr.jelinek@2ndquadrant.com, andres@anarazel.de, michael@paquier.xyz, alvherre@2ndquadrant.com, jd@commandprompt.com
  Subject: Re: replication_slots usability issue
  In-Reply-To: <c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox