From: Christian Ullrich <chris@chrullrich.net>
To: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: C nitpick about pgwin32_dispatch_queued_signals()
Date: Sun, 2 Nov 2025 13:05:47 +0000
Message-ID: <cc4ef8db-f8dc-4347-8a22-e7ebf44c0308@chrullrich.net> (raw)
Hello,
the current MSVC compiler deems it necessary to issue
warning C4053: one void operand for '?:'
for a line with CHECK_FOR_INTERRUPTS(). This boils down to this bit of
miscadmin.h (line 116 in master):
#define INTERRUPTS_PENDING_CONDITION() \
(unlikely(UNBLOCKED_SIGNAL_QUEUE()) ?
pgwin32_dispatch_queued_signals() : 0, \
unlikely(InterruptPending))
#endif
The C spec says that of the possible results of the :? operator, either
none or both can be void, and pgwin32_dispatch_queued_signals() is void
(and has been as far back as I can find it).
Does that matter?
--
Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: chris@chrullrich.net, pgsql-hackers@lists.postgresql.org
Subject: Re: C nitpick about pgwin32_dispatch_queued_signals()
In-Reply-To: <cc4ef8db-f8dc-4347-8a22-e7ebf44c0308@chrullrich.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox