From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_waldump: Add a --quiet option.
Date: Fri, 3 Apr 2020 10:41:09 +0900
Message-ID: <d332b8f0-0c72-3cd6-6945-7a86a503662a@oss.nttdata.com> (raw)
In-Reply-To: <E1jKAs1-0006vN-9N@gemulon.postgresql.org>
References: <E1jKAs1-0006vN-9N@gemulon.postgresql.org>
On 2020/04/03 10:11, Robert Haas wrote:
> pg_waldump: Add a --quiet option.
>
> The primary motivation for this change is that it will be used by the
> upcoming patch to add backup manifests, but it also seems to have some
> potential more general use.
I'm not sure what the actual purpose of this feature yet, but ISTM that
the following change is necessary. Otherwise, "empty" stats information
is output even when --quiet is specified.
- if (config.stats == true)
+ if (config.stats == true && !config.quiet)
XLogDumpDisplayStats(&config, &stats);
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_waldump: Add a --quiet option.
In-Reply-To: <d332b8f0-0c72-3cd6-6945-7a86a503662a@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox