pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm
Date: Wed, 6 Feb 2019 20:34:11 -0500
Message-ID: <e4b0f366-269c-73c3-9c90-d9cb0f4db1f9@2ndQuadrant.com> (raw)


These two files are used by TAP test suites but fall foul of the
tightening of perl's searchpath rules. See for example
<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2019-02-07%2000%3A10%3A31;

The obvious solution is to perform the same surgery for the ssl and
pg_rewind tests that we performed for genbki.pl and other scripts, but
in these cases the used modules are not in the same directory as the
using scripts, but in their parent directories. I can't think of a good
reason for this.They clearly relate to the TAP test suites, and nothing
else, so it seems to me that they should go into the same directory as
the TAP test scripts. There should be no danger that "prove" will try to
run them, as it is only set up to run files with a ".pl" extension.

While we're at it, I think ServerSetup.pm should possibly be renamed to
something like SSLServer.pm (and the perl code adjusted accordingly)

Does anyone object to me making these changes?

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (5+ messages)  latest in thread

Message-ID: <e4b0f366-269c-73c3-9c90-d9cb0f4db1f9@2ndQuadrant.com>
Permalink:  ../e4b0f366-269c-73c3-9c90-d9cb0f4db1f9@2ndQuadrant.com/
Also on:    postgresql.org/message-id/e4b0f366-269c-73c3-9c90-d9cb0f4db1f9@2ndQuadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew.dunstan@2ndquadrant.com
  Subject: Re: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm
  In-Reply-To: <e4b0f366-269c-73c3-9c90-d9cb0f4db1f9@2ndQuadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox